Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search suggestions in Firefox #2884

Closed
artemiv4nov opened this issue Jun 27, 2019 · 3 comments
Closed

Fix search suggestions in Firefox #2884

artemiv4nov opened this issue Jun 27, 2019 · 3 comments
Assignees
Milestone

Comments

@artemiv4nov
Copy link
Contributor

We have bug: when user enters something in the address bar of firefox, then it doesn't show suggestions. This can happen because the browser doesn't trust user certificates and search engines' requests breaks up.

How to reproduce:

  1. Install latest version of Firefox;
  2. Go to duckduckgo.com and setup as default search engine;
  3. Try entering something in the address bar with turned off AdGuard's protection: browser should show suggestions;
  4. Turn on AdGuard's protection;
  5. Entering something in the address bar again, suggestions should not be show.
@artemiv4nov artemiv4nov self-assigned this Jun 27, 2019
@artemiv4nov artemiv4nov changed the title Improve communication between proxy server and Firefox Fix search suggestions in Firefox Jun 27, 2019
@artemiv4nov artemiv4nov transferred this issue from AdguardTeam/AdguardForAndroid Jul 4, 2019
@artemiv4nov artemiv4nov transferred this issue from AdguardTeam/AdguardForWindows Jul 4, 2019
@artemiv4nov artemiv4nov added this to the 3.2 milestone Jul 4, 2019
@artemiv4nov
Copy link
Contributor Author

After all we decided to keep everything as it is now.

@GyokuroT
Copy link

GyokuroT commented Jul 23, 2019

In the latest beta release notes you marked this issue as fixed. On GitHub the other hand you closed it without a fix.

@ameshkov
Copy link
Member

@GyokuroT yup, thanks for noticing.

Let me please explain why we decided to keep the current behavior. The problem is that if we try to fix it, we risk breaking HTTPS filtering of the search domains.

There is a simple workaround for Duckduckgo, though: simply adding ac.duckduckgo.com to the HTTPS filtering exclusions will fix the issue. On the other hand, for Google we'll have to exclude www.google.com completely -> we won't be able to block search ads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants