Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept subscribe.adblockplus.org links #2930

Closed
adbuker opened this issue Jul 17, 2019 · 2 comments
Closed

Intercept subscribe.adblockplus.org links #2930

adbuker opened this issue Jul 17, 2019 · 2 comments
Assignees
Milestone

Comments

@adbuker
Copy link

adbuker commented Jul 17, 2019

related to AdguardTeam/AdguardForWindows#2517
Now we have the custom URL protocol adguard:subscribe used in order to install new filter subscription (e.g. adguard:subscribe?location=...). The syntax is quite similar to the apb's custom protocol.
The detailed work scheme described in the related win's PR

@ameshkov ameshkov added this to the 3.3 milestone Jul 25, 2019
@ameshkov ameshkov changed the title Implement filter subscription detection message's handler Intercept subscribe.adblockplus.org links Jul 25, 2019
@ameshkov
Copy link
Member

Currently, it's partly implemented in #2918

However, it does not intercept subscribe.adblockplus.org links:
#2918 (comment)

Part of this logic is on the CoreLibs side -- it replaces subscribe.adblockplus.org with adguard:subscribe

@admitrevskiy
Copy link

Done (v3.3)

Testing instructions for QA:
-Reinstall AG
-Don't enable protection
-Go to https://adblockplus.org/subscriptions
-Tap on any subscription link

Expected result:
-Same as #2918 (comment)

@zzebrum zzebrum closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants