New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress HTTPS filtering error notification for the apps that use pinning techniques #3052
Comments
Does the user have HTTPS filtering enabled for Outlook? We don't filter it by default |
I guess not, can be reproduced with default settings (after a clean install of the application). |
New logs in ncloud. |
For me it really is not "from time to time" but constantly and it completely breaks HTTP Filtering. |
I suppose this is your mail to support - 2354792 |
Yes it is, sorry, I forgot to mention it here after sending in a support request. Btw., there seems to be no good way to work around this bug(?) in Beta except by adding every single App or Domain to the whitelist. Disabling the notifications in the low level settings causes some Apps to be unable to open any TLS connections at all. |
Some of the apps do TLS pinning and HTTPS filtering won't work for them. Ideally, you should disable HTTPS filtering for such apps. |
@AdguardTeam/developers I think we should have a list of apps known for using TLS pinning and suppress this notification for them. We should expose this list via low-level settings to make it transparent to the users. |
What was the default behavior before the notification was added? I haven't seen this notification before the last beta update, but had no problems with the same applications. I find it highly unlikely that almost all apps have suddenly started using certificate pinning for domains like crashlytics.com. Additionally, I was able to use all of them without in-app ads before. |
BTW., the exclude domain button from the notification does not seem to work for me, as it always overrides the last domain added to the HTTPS whitelist. (Therefore, you can only always add a single domain to the whitelist and it is getting replaced by the next one.) |
I can confirm the issue Murgeye mentioned above. Running latest beta 3.3.2. |
The bug was present in 3.3 beta 1 as well by the way. |
This bug will be fixed in beta 3. |
So here's what we have here:
|
Somehow from time to time user will receive a notification (see attachment) about HTTPS filtering error that some application does not accept our certificate. It can not be reproduced easily but it does exist.
The text was updated successfully, but these errors were encountered: