Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not good mimicry #3087

Closed
AlikhanAliev opened this issue Sep 26, 2019 · 4 comments
Closed

Not good mimicry #3087

AlikhanAliev opened this issue Sep 26, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@AlikhanAliev
Copy link

AlikhanAliev commented Sep 26, 2019

Our toasts mimic snacks but not exactly. We have to correct a font size and an align and an toast height. Also we should remove a dot and use a short showing time for this element.

image

@admitrevskiy
Copy link

Done.

Testing instructions for QA:

  • Reinstall AG
  • Disable all filters
  • Go to main screen
  • You will see Enable filters snackbar
  • Change configuration to trigger protection restart (enable/disable HTTPS or DNS filtering for example)
  • Go back to the main screen
  • You will see New settings were applied notification

Expected result:

  • Notification font, sizes and margins are the same with the snackbar

@slavaleleka
Copy link

I suggest to use Present Perfect for such notification — 'New settings have been applied' and 'Filtering rule has been added'. Also there're different shades of green

slbdzd8l z2r3e


In this case yellow notification is lower than green one, it has center alignment of text and it seems like there is bigger font size

slbdzd8l sknhs

@slavaleleka
Copy link

I guess 'The text's been copied to the clipboard' would be better here too
+ one more different shade of green

slbdzd8l wgbey

@admitrevskiy
Copy link

admitrevskiy commented Oct 3, 2019

Done.

Toast should overlap any single line snack.

@zzebrum zzebrum closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants