Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the SHA-1 intermediate issue #1702

Closed
ameshkov opened this issue Apr 19, 2017 · 9 comments
Closed

Fix the SHA-1 intermediate issue #1702

ameshkov opened this issue Apr 19, 2017 · 9 comments
Assignees
@adbuker
Labels
security
Milestone
6.2

Comments

@ameshkov
Copy link
Member

This is part of SHA-1 deprecation, we should examine intermediate certificates as well:
https://sha1-intermediate.badssl.com
@ameshkov ameshkov added this to the 6.2 milestone Apr 19, 2017
@ameshkov
Copy link
Member Author

Done

@ameshkov
Copy link
Member Author

Review ID: ADWIN-CR-189

This was referenced Apr 19, 2017
Closed
Closed
@ameshkov
Copy link
Member Author

Ok, that was too early to celebrate.

@ameshkov ameshkov reopened this Apr 19, 2017
@ameshkov
Copy link
Member Author

Fixed

@ameshkov
Copy link
Member Author

Found an issue with the current implementation.

@ameshkov ameshkov reopened this Jun 21, 2017
@ameshkov
Copy link
Member Author

And here are the consequences of my flawed implementation:
AdguardTeam/AdguardAssistant#66

Too strict.

@ameshkov ameshkov mentioned this issue Jun 23, 2017
Closed
@adbuker
Copy link

adbuker commented Jul 20, 2017

resolved in ADWIN-CR-232

@adbuker adbuker closed this as completed Aug 1, 2017
@ameshkov
Copy link
Member Author

ameshkov commented Aug 3, 2017

Something is wrong with the fix, this website is not filtered due to SHA-1 check: https://www.torrentleech.org/

@ameshkov ameshkov reopened this Aug 3, 2017
@ameshkov
Copy link
Member Author

There's no bug actually, the issue is caused by the server's incomplete chain

@vozersky vozersky added beta and removed beta labels Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbuker adbuker

Labels
security
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
4 participants
@ameshkov @confessor-adguard @vozersky @adbuker