Fixed elvis warnings and bumped rebar3 version to 3.19.0 for the CI (#52

)

* Fixed elvis warnings and bumped rebar3 version to 3.19.0 for the CI

* Changed function ensure_all_started as it was returning something not useful

.github/workflows/erlang.yml

@@ -10,8 +10,8 @@ jobs:
 
     strategy:
       matrix:
-        otp: ['23.3']
-        rebar: ['3.16.1']
+        otp: ['23.3', '24.3']
+        rebar: ['3.19.0']
 
     steps:
     - uses: actions/checkout@v2

src/erlmld_app.erl

@@ -2,7 +2,7 @@
 
 -behaviour(application).
 
--export([start/2, stop/1, ensure_all_started/0]).
+-export([start/2, stop/1, ensure_all_deps_started/0]).
 
 %% application callback.  load default configuration from application environment, and
 %% start erlmd_sup with that configuration.
@@ -15,11 +15,7 @@ start(_StartType, []) ->
 stop(_State) ->
     ok.
 
-ensure_all_started() ->
+ensure_all_deps_started() ->
     {ok, Deps} = application:get_key(erlmld, applications),
-    {ok,
-     lists:append([begin
-                       {ok, Started} = application:ensure_all_started(Dep),
-                       Started
-                   end
-                   || Dep <- Deps])}.
+    lists:foreach(fun(Dep) -> {ok, _} = application:ensure_all_started(Dep) end, Deps),
+    ok.

src/erlmld_wrk_statem.erl

@@ -103,6 +103,9 @@
 %%%-------------------------------------------------------------------
 -module(erlmld_wrk_statem).
 
+%% The usage of throw here is intentional because gen_statem knows how to handle throws
+-elvis([{elvis_style, no_throw, disable}]).
+
 -behaviour(gen_statem).
 
 %% API