Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spot price field for LaunchConfiguration #438

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

gronpipmaster
Copy link
Contributor

No description provided.

@alimoeeny
Copy link
Contributor

Hi @gronpipmaster thanks for your contribution, would you please sign the cla ? then we can merge your commit.

@gronpipmaster
Copy link
Contributor Author

gronpipmaster commented May 12, 2017

Hi, im agree

@gronpipmaster
Copy link
Contributor Author

And I forgot how it's done :( Please remind me how to do this.

@alimoeeny
Copy link
Contributor

mmm, good point, I guess you should see a link to https://cla-assistant.io/ but I don't see it. Maybe because I have already accepted it before.
or maybe github is having a problem.
If you have not done this already try visiting https://cla-assistant.io/

@gronpipmaster
Copy link
Contributor Author

I tried again, accept the rights by deleting the cookie for https://cla-assistant.io/AdRoll/goamz?pullRequest=438 and assistant show me this
scrin9
it's not affected and im see this
scrin8
I do not know what else you can do :(

@alimoeeny
Copy link
Contributor

alimoeeny commented May 12, 2017

:( this looks like a github problem. or maybe cla-assistant problem.
Unfortunately I don't have access to the gods.
Let's wait a while and see if it is solved, it must also affect other people.

@gronpipmaster
Copy link
Contributor Author

Hi, I looked for the same problem, and found a solution cla-assistant/cla-assistant#124

@alimoeeny
Copy link
Contributor

Thanks @gronpipmaster
Unfortunately since the ownership of the repo has changed I don't even know who has access to do this. I definitely don't. Maybe @aaaron or @dialtone or @james-kelly can help us with this.

@dialtone dialtone merged commit 2f6bb0f into AdRoll:master Jul 5, 2017
@alimoeeny
Copy link
Contributor

Thanks @dialtone

@gronpipmaster gronpipmaster deleted the support-spot-price branch July 5, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants