Add a CreateQueueWithParams function #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port 4444 conflicts with another service run by Mac OS X Server on Mavericks.
This makes it possible to run the tests as you develop, especially if you are developing against a github fork.
This allows you to set arbitrary attributes when creating a queue, like setting WaitTimeSeconds to allow for long-polling. Reimplement CreateQueueWithTimeout in terms of CreateQueueWithParams and add unit tests for both functions.
|
Hold off on this PR for now... Turns out that |
|
Understood! Thanks for your work on this :) |
According to the SQS docs, the visibility timeout needs to be provided as an attribute, and with the name "VisibilityTimeout".
|
Ok, pushed a commit which fixes the behavior and renames the function to |
moorage
pushed a commit
that referenced
this pull request
Jan 21, 2014
Add a CreateQueueWithParams function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to pass along arbitrary attributes when creating a queue, for example
WaitTimeSecondsfor long polling. It takes amap[string]string, andCreateQueueWithTimeoutis changed to be implemented in terms of it.This PR also includes a few changes to the test suite, most notably that the tests are moved into the same package as the code. This is idiomatic, and makes it possible to run the tests while you are developing the code. It also moves the test server to a different port to avoid conflicting with services that run as part of OS X Server.