Installer support for OS X 10.11 (El Capitan) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use of the newly introduced System Integrity Protection in OS X 10.11
… reference the new path in /usr/local/bin
|
As noted in another Pull Request, I'm not sure if AdRoll still wants to maintain this project. I've forked it over at https://github.com/sanctuarygroup/hologram - can you please move this change there and I'll provide commentary? |
|
Can this be merged? Now that El Capitan is out, this breaks hologram in the common case. |
|
will it do the right thing if you have a previous version installed and install this, or will you end up with two binaries? |
|
@walterking Just added to the postinstall.sh to remove the previous binaries if they exist under |
walterking
added a commit
that referenced
this pull request
Oct 1, 2015
Installer support for OS X 10.11 (El Capitan)
|
Thanks! |
| @@ -2,13 +2,30 @@ | |||
| # Remove the previous version of Hologram. | |||
| launchctl unload -w /Library/LaunchDaemons/com.adroll.hologram.plist | |||
|
|
|||
| # Remove previous (old location) hologram binaries if they exist | |||
| if [ -f "/usr/bin/hologram-boot" ]; then | |||
| rm /usr/bin/hologram-boot | |||
There was a problem hiding this comment.
This might not work on some systems. I would rather go for `rm -f'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El Capitan introduces System Integrity Protection which does not allow writing out to certain "protected" directories. Because of the this the installer throws a warning and does not complete
The change is minor though we may want to discuss the best method here. I've globally changed it to write to /usr/local/bin. We could also throw a version condition in here if we want to only install to local on 10.11 and above.