Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktn_dodger can't parse macros in specs #48

Closed
elbrujohalcon opened this issue Dec 30, 2019 · 1 comment
Closed

ktn_dodger can't parse macros in specs #48

elbrujohalcon opened this issue Dec 30, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@elbrujohalcon
Copy link
Collaborator

elbrujohalcon commented Dec 30, 2019 •
edited
Loading

There are two issues in ktn_dodger ( inaka/katana-code#37 and inaka/katana-code#38 ) that prevent it from parsing macros in specs correctly.
Therefore, once the issue is fixed there, we should upgrade the dependency here ASAP.
@elbrujohalcon elbrujohalcon added the bug Something isn't working label Dec 30, 2019
@elbrujohalcon elbrujohalcon changed the title ktn_dodger can't parse macros surrounded with parentheses ktn_dodger can't parse macros in specs Dec 30, 2019
elbrujohalcon pushed a commit that referenced this issue Dec 30, 2019
Macros in specs are not parsed correctly (#48)
97e790b
elbrujohalcon pushed a commit that referenced this issue Jan 2, 2020
Verify the result of the formatting (#43)
a99a9ed 
* Add AST validation after formatting.

* Attributes can't appear between function definitions.

* Floating point numbers are poorly formatted (#24)

* Macros in specs are not parsed correctly (#48)
@elbrujohalcon elbrujohalcon added this to the 0.3.0 milestone Apr 9, 2020
@elbrujohalcon elbrujohalcon removed this from the 0.3.0 milestone Apr 27, 2020
@elbrujohalcon elbrujohalcon added this to the After Improving ktn_code milestone May 6, 2020
@elbrujohalcon
Copy link
Collaborator Author

This is fixed already.

-spec ?MODULE:f(?PAIR(r0(), r0())) -> ?PAIR(t(), t()).
-spec ?MODULE:b() -> ?BOMBA | fun().

…is correctly formatted as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elbrujohalcon