Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Xinran #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Branches - Xinran #27

wants to merge 11 commits into from

Conversation

gracexinran
Copy link

@gracexinran gracexinran commented Dec 13, 2019 •
edited
Loading

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? Show/hide some html elements in different conditions, eg: recent submission form is hided for first player / recent submission and submission form are hided after submitting the final poem
How was this project similar to in-class examples? Submit form and pass data to parent component, apply callback functions, save data in state and pass data to children components as props
If you had time to refactor one part of this project, what would you do to make it better? Remove the unnecessary state variables of game component, same data can be retrieved by fewer state variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gracexinran