Leaves - Cloudy #53
Open
Leaves - Cloudy #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd models for work user abnd vote
…c for views show, new, index, and edit
…e homepages controller by adding index to it.
…ed 12 various works so i can ensure the top ten will work
…. checked validations
…. created custom method for top ten and spotlight.
…tml show the users who have voted.
dHelmgren
reviewed
Oct 29, 2019
| root 'works#index' | ||
|
|
||
| resources :works | ||
| resources :homepages |
There was a problem hiding this comment.
This is unnecessary. You don't use the majority of these routes.
Comment on lines
+14
to
+22
| <h3>MOVIES</h3> | ||
| <ul> | ||
| <% movies = Work.topten(category: "movie") %> | ||
| <% movies.each do |movie| %> | ||
| <li> | ||
| <%= link_to movie.title, work_path(movie.id) %> | ||
| </li> | ||
| </ul> | ||
| <% end %> |
There was a problem hiding this comment.
This code is repeated, you can use a view partial to DRY this up.
| expect(book.save).must_equal false | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
you need tests for your model methods.
|
|
||
| <p><%= @work.description%></p> | ||
| <p><%= link_to "Back to Media Ranks", works_path %></p> | ||
| <p><%= link_to "Edit", works_path %></p> |
There was a problem hiding this comment.
this is the wrong path. it should be edit_works_path. You can get that information using rails routes in the terminal
Comment on lines
+8
to
+12
| <p><%= @work.description%></p> | ||
| <p><%= link_to "Back to Media Ranks", works_path %></p> | ||
| <p><%= link_to "Edit", works_path %></p> | ||
| <p><%= link_to "Upvote", vote_path(@work.id), method: :post %></p> | ||
| <p><%= link_to "Delete", work_path(@work.id), method: :delete, data: {confirm: "Are you sure?"}%></p> |
There was a problem hiding this comment.
Should this be a series of <p> tags or a <ul> with <li> tags?
Media RankerWhat We're Looking ForManual Testing
Targeted Code Review
Targed Test Review
Overall FeedbackThis project is clearly still in-progress. It looks like a lot of the features got implemented most of the way, but there are some pretty clear problems outlined above. In the future, please tell your instructors about projects like this. Our goal is to help bridge the gap between where y'all are and where we need y'all to be, and part of that is being able to communicate about your progress. Let's take a minute to talk later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?