-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sarah Jane Olivas - Spruce - C16 #35
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💫 Overall, a nice implementation, Sarah. For the comprehension questions, we can say that a heap is weakly ordered. There is an ordering property, but it's less strict that the left-right ordering of a BST. And while we could use a linked list for our implementation, this would be much less efficient, since we could not access elements directly via index.
The implementation of heap_down
appears to share some code with the instructor solution. As such, I don't feel I can fully evaluate your approach to that implementation. As a result, I am giving the overall implementation a yellow. Yellow does not require a resubmission.
Please let me know if you'd like to discuss this further, or feel free to submit a new implementation for heap_down
and I'll re-evaluate.
🟡
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up
&heap_down
methods useful? Why?