Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nina and Sassa PR #41

Open
wants to merge 170 commits into
base: master
Choose a base branch
from
Open

Nina and Sassa PR #41

wants to merge 170 commits into from

Conversation

ninamutty
Copy link

RedSquirrelious and others added 30 commits October 3, 2016 21:31
… market_id 1x in order, 1x from vendors sorted by name, 1x by vendors sorted by num employees
added product and sale models, added seed data
@RedSquirrelious
Copy link

@PilgrimMemoirs

What I worked on in the FarMarRails Project
I worked on the Vendors section, creating the model and controller and handling functionality for products (Nina handled the sales functionality and the CSS portion). I also created the search functionality for markets by product.

What worked well in terms of teamwork
We were very supportive of each other. We communicated strategy at the beginning. We took on different portions and traded off. The backend portion seemed equitable.

What didn't go as well in terms of teamwork
We didn't follow up much with each other throughout the project. I think we got buried in the work and had a hard time coming out of it. That was what it was for me, anyhow. It would have been good to set times to talk (e.g., "at 2:00 we talk about XYZ, at 4:00 we talk about ABC").
I also went down a rabbit hole on something not necessary (celebrities) and should have done more with the front-end design. Nina took care of it, but I should have been a better partner and pulled my weight on it.

Technical parts that went well and parts that didn't
Things went very well for the baseline work and the search functionality. Nina did a great job making our site look good. I had a hard time with the other add on (the celebrities) and it took up time. I got it to work but we ran out of time in class to style it.

@ninamutty
Copy link
Author

ninamutty commented Oct 11, 2016

@PilgrimMemoirs - Nina's Farmar Rails Code Journal

  1. What I worked on in the FarMarRails Project
    I created the market and vendor models and created the controller and views for market. For the vendor controller and views, I also did the sales (creating new and seeing all) and worked on editing capabilities for a vendor's products. Finally, I did the CSS for the landing page, market functionality and vendor functionality.
  2. What worked well in terms of team work
    I think that we did a good job in planning out our steps before hand and what we wanted the project to look at and we did a good job pushing each other to go beyond the baseline expectations. Some of the extras we added were a many-to-many relationship between markets and vendors (we edited the csv so vendors participated in multiple markets), having different editing functionality depending if you use the site as a market or vendor, being able to search for markets by product and Sassa's working on adding random celebrity sightings and quotes to the markets.
  3. What didn't go as well in terms of teamwork
    I think we could've improved our troubleshooting together. At times I found it hard to collaborate on issues (we did have a couple strange and unusual ones..) because we had separated out responsibilities and were working on the individually, so if someone had an issue it was hard to quickly dive in to the other person's code to figure out what the issue was and how we could fix it. I felt like we relied on teachers and ta's more than was maybe necessary.
  4. Technical parts that went well and parts that didn't.
    For me, the CSS went well and I think I'm getting faster at it. I really like the finished product of my work. I also think the flow of steps to take to create market and vendor functionality is coming much easier with practice. Things to improve on are using datetime (was search by month an optional feature for sales? Someone said it was so we didn't add in that functionality, but now I think we should have..), and I think it would've been nice to have search by name functionality too and like I said above, I think we could've done a better job trouble shooting together. Also pushing to Heroku was a big pain (especially because we had some plurals/singulars off) and we edited the CSV files and left them a little messy which caused a lot of problems at various times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants