Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FarMar Complete #57

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Conversation

BrandiPhillips
Copy link

Having issues deploying it to Heroku, Chris is helping now. :)

BrandiPhillips and others added 30 commits October 4, 2016 15:28
Added SessionsController and helper for persistent memory of user ide…
Added user loop - merged into master
… (does not include addition/removal of Vendors from Markets)
Merging in the Market edit and creation loop
Sale and product loops added with basic functionality
Added dropdowns, DRYed forms, and modified login
@BrandiPhillips
Copy link
Author

@BrandiPhillips
Copy link
Author

@eabrash
Copy link

eabrash commented Oct 10, 2016

Here is the Heroku link (currently to a copy of our FarMar that is on my GitHub, which I was using as we were trying to troubleshoot our deployment issues): https://bmp-ea-farmar-2.herokuapp.com/

UPDATE (Mon. Oct 11): here is the link to the Heroku app that is correctly linked to our actual repo (the one in Brandi's GitHub): https://farmar-app-bmp-ea.herokuapp.com/

Re-merging Heroku-ready version into master
@BrandiPhillips
Copy link
Author

@CheezItMan - I worked on allowing the user to indicate what type of user they are based off what link they chose to click on the home page. I also worked on the market user's capabilities - creating/editing a market and viewing/creating/editing products. Then I worked on all of the css for the layout of the site and much of the html related to layout (footers/headers/html layout related elements). Discussing the user stories and setting priorities then drawing out the flow of our site together discussing how we envision the user experience to be at each page was very helpful through out the project as well as checking with each other. I think we could have used Trello a little more effectively along the way. We could have maybe broken out the user stories into more specific tasks in Trello... I was impressed with how we tackled the technical aspects of the project. I am also impressed with @eabrash 's ability to work out problems so quickly and efficiently!! I am appreciative of her patience as sometimes it takes me a little longer to work things out and understand how to bring them together. Lesson learned - Always allow Rails to set up the .gitignore file for you!!! :)

@eabrash
Copy link

eabrash commented Oct 11, 2016

Emily's Code Journal - @CheezItMan

What I worked on:

Below is a picture that Brandi and I made to help us organize who was working on what in the project. This was really helpful for guiding our discussions, and is also helpful for pointing out the parts that I worked on. I did most of the underlying code for the "Guest loop" (pages related to the users controller), the "Market loop" (market controller), and the "Sales/product loop" (sales and product controllers), but did not do any of the styling as that was something Brandi wanted to focus on in this project.

brandi_emily_farmarrails

Teamwork - what worked well:

Brandi was a great partner to work with for FarMar. She and I have worked together on a pair project before, and I think this time we were better equipped with techniques and strategies for working as a team. We worked together to build the basic framework to which the various parts of the project would connect, then split up more discrete tasks to do separately. The diagram (above) was extremely helpful for guiding our discussions and making it possible to split up work in a well-defined way, as well as to discuss design considerations and ideas concretely and with a shared understanding. We worked together doing real pair programming for some core sections, as well as if one of us was running into problems and needed another pair of eyes on the code.

Teamwork - what didn't go as well:

One thing that I think I could improve at in terms of teamwork is keeping my hands off of parts of code that aren't explicitly what I'm supposed to be working on. I tended to want to "just make a little tweak" to some other part of the code, and that resulted in a lot of merge conflicts that we had to resolve manually. It wasn't a disaster, but in a future teamwork context, I would definitely want to be much more careful about only touching things in my well-defined work area and not messing with things that others might be modifying.

Technical parts - what went well and poorly:

Overall, I felt like I was a little confused about when we could and couldn't depart from standard RESTful routes. It sometimes felt awkward or artificial to use the pre-defined controller actions and views (update, create, new, delete, index, etc.) to accomplish what I wanted to accomplish, and we sometimes ended up mixing methods and views from different controllers in ways that felt confusing (or like they would be confusing to someone else trying to interpret or maintain the code). I also would have really liked to know how to do a proper login. I tried doing a persistent session, which was an OK stopgap, but when I tried to add checks to ensure the correct identity of the user for certain pages, it worked fine on my computer with localhost but broke on Heroku (and so the user identity check is not in the "shipped" version of the site - meaning a market could hop over to a vendor page by changing the URL and see wrong information).

@BrandiPhillips
Copy link
Author

That is true, I only worked on the vendor part of the market loop. I forgot. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants