Skip to content

Commit

Permalink
Fix test checks, Number addition
Browse files Browse the repository at this point in the history
ref #344
  • Loading branch information
jklmnn committed Aug 21, 2020
1 parent 253d047 commit 3ec4867
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion rflx/pyrflx/typevalue.py
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ def _get_first(self, fld: str) -> Optional[Number]:
length = self._fields[prv].typeval.size
assert isinstance(first, Number)
assert isinstance(length, Number)
return Number(first.value + length.value)
return first + length
if prv and UNDEFINED not in (self._fields[prv].first, self._fields[prv].typeval.size):
first = self.__simplified(Add(self._fields[prv].first, self._fields[prv].typeval.size))
return first if isinstance(first, Number) else None
Expand Down
6 changes: 3 additions & 3 deletions tests/test_pyrflx.py
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,7 @@ def test_no_verification_icmp(icmp: MessageValue) -> None:
icmp_unv.set("Identifier", 5)
icmp_unv.set("Sequence_Number", 1)
icmp_unv.set("Data", b"\x00")
assert icmp.bytestring == icmp_unv.bytestring
assert icmp_unv.bytestring == icmp.bytestring


def test_no_verification_ethernet(frame: MessageValue) -> None:
Expand All @@ -1619,7 +1619,7 @@ def test_no_verification_ethernet(frame: MessageValue) -> None:
frame_unv.set("Type_Length", int("0800", 16))
frame_unv.set("Payload", payload)
assert frame_unv.valid_message
assert frame.bytestring == frame_unv.bytestring
assert frame_unv.bytestring == frame.bytestring


def test_no_verification_array_nested_messages(
Expand All @@ -1645,7 +1645,7 @@ def test_no_verification_array_nested_messages(
array_message_unv.set("Length", 2)
array_message_unv.set("Bar", foos_unv)
assert array_message_unv.valid_message
assert array_message.bytestring == array_message_unv.bytestring
assert array_message_unv.bytestring == array_message.bytestring

array_message_unv = array_message_package_unv["Message"]
array_message_unv.parse(b"\x02\x05\x06")
Expand Down

0 comments on commit 3ec4867

Please sign in to comment.