Detects duplicate messages and channels aspects

This commit introduces extra checks to avoid duplicate aspects for messages and channels.
Closes #714

rflx/specification/parser.py

@@ -997,7 +997,9 @@ def extract_aspect(aspects: lang.AspectList) -> Tuple[expr.Expr, expr.Expr]:
         size: expr.Expr = expr.UNDEFINED
         first: expr.Expr = expr.UNDEFINED
         for aspect in aspects:
-            if (aspect.f_identifier.text == "Size" and size != expr.UNDEFINED) or (aspect.f_identifier.text == "First" and first != expr.UNDEFINED):
+            if (aspect.f_identifier.text == "Size" and size != expr.UNDEFINED) or (
+                aspect.f_identifier.text == "First" and first != expr.UNDEFINED
+            ):
                 error.extend(
                     [
                         (

tests/unit/specification/parser_test.py

@@ -1995,6 +1995,80 @@ def test_parse_error_duplicate_channel_aspect_readable() -> None:
         r'^<stdin>:11:60: parser: error: duplicate aspect "Readable"',
     )
 
+def test_parse_error_duplicate_message_aspect_size() -> None:
+    assert_error_string(
+        """
+            package Test is
+                type M is
+                    message
+                        B : Opaque
+                            with First => 123, Size => 123, Size => 521;
+                    end message;
+            end Test;
+        """,
+        r'^<stdin>:6:61: parser: error: duplicate aspect "Size"',
+    )
+
+
+def test_parse_error_duplicate_message_aspect_first() -> None:
+    assert_error_string(
+        """
+            package Test is
+                type M is
+                    message
+                        B : Opaque
+                            with First => 123, Size => 123, First => 521;
+                    end message;
+            end Test;
+        """,
+        r'^<stdin>:6:61: parser: error: duplicate aspect "First"',
+    )
+
+
+def test_parse_error_duplicate_channel_aspect_readable() -> None:
+    assert_error_string(
+        """
+        package Test is
+
+            type M is
+                message
+                    B : Opaque
+                        with Size => 8;
+                end message;
+
+            generic
+                Channel : Channel with Readable, Writable, Readable;
+            session Session with
+                Initial => Start,
+                Final => Terminated
+            is
+                Message : M;
+            begin
+                state Start is
+                begin
+                    Channel'Read (Message);
+                transition
+                    goto Reply
+                        if Message'Valid
+                    goto Terminated
+                end Start;
+
+                state Reply is
+                begin
+                    Channel'Write (Message);
+                transition
+                    goto Terminated
+                end Reply;
+
+                state Terminated is null state;
+            end Session;
+
+        end Test;
+        """,
+        r'^<stdin>:11:60: parser: error: duplicate aspect "Readable"',
+    )
+
+
 def test_parse_error_duplicate_channel_aspect_writable() -> None:
     assert_error_string(
         """
@@ -2036,7 +2110,9 @@ def test_parse_error_duplicate_channel_aspect_writable() -> None:
         end Test;
         """,
         r'^<stdin>:11:60: parser: error: duplicate aspect "Writable"',
-    )  
+    )
+
+
 @pytest.mark.parametrize("spec", ["empty_file", "comment_only", "empty_package", "context"])
 def test_create_model_no_messages(spec: str) -> None:
     assert_messages_files([f"{SPEC_DIR}/{spec}.rflx"], [])