Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax length precondition of To_Context #1054

Closed
treiher opened this issue May 25, 2022 · 0 comments · Fixed by #1060
Closed

Relax length precondition of To_Context #1054

treiher opened this issue May 25, 2022 · 0 comments · Fixed by #1060
Assignees
@treiher
Labels
bug generator Related to generator package (SPARK code generation)
Projects
RecordFlux 0.6

Comments

@treiher
Copy link
Collaborator

treiher commented May 25, 2022

Currently, one of the preconditions of To_Context is that the length of the buffer of the context must be at least as long as the longest possible message. This is unnecessarily restrictive. It should be possible to calculate the concrete length of the message in Struct and use this value in the precondition.

Additionally, in the generated session code, the length condition should be checked before calling To_Context.
@treiher treiher added bug generator Related to generator package (SPARK code generation) labels May 25, 2022
@treiher treiher self-assigned this May 25, 2022
@treiher treiher added this to To do in RecordFlux 0.6 via automation May 25, 2022
@treiher treiher moved this from To do to Implementation in RecordFlux 0.6 May 25, 2022
treiher added a commit that referenced this issue May 31, 2022
@treiher
Relax length precondition of To_Context
1c765a9 
Ref. #1054
treiher added a commit that referenced this issue May 31, 2022
@treiher
Check preconditions before calling To_Context
edcffc5 
Ref. #1054
treiher added a commit that referenced this issue May 31, 2022
@treiher
Check preconditions before calling To_Context
1e49a2e 
Ref. #1054
@treiher treiher mentioned this issue May 31, 2022
Merged
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Relax length precondition of To_Context
fc80b88 
Ref. #1054
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Check preconditions before calling To_Context
0a2dafd 
Ref. #1054
@treiher treiher moved this from Implementation to Review in RecordFlux 0.6 Jun 1, 2022
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Relax length precondition of To_Context
647e01d 
Ref. #1054
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Check preconditions before calling To_Context
8a777f2 
Ref. #1054
RecordFlux 0.6 automation moved this from Review to Done Jun 1, 2022
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Relax length precondition of To_Context
aa1cb6d 
Ref. #1054
treiher added a commit that referenced this issue Jun 1, 2022
@treiher
Check preconditions before calling To_Context
298e6fe 
Ref. #1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@treiher treiher

Labels
bug generator Related to generator package (SPARK code generation)
Projects
No open projects
RecordFlux 0.6
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1039, 1042, 1054: Fix code generator AdaCore/RecordFlux
1 participant
@treiher