Missing check of size and alignment of opaque fields

[treiher]

The generated getters and setters for opaque fields assume that the field is byte-aligned and its bit length is a multiple of 8. This is currently not ensured. Getters and setters for opaque fields should be only generated if these assumptions are met. We should check that in the model.

[senier]

Getters and setters for opaque fields should be only generated if these assumptions are met.

Shouldn't we just reject the model in such cases? Do we know of examples that have non-byte-aligned opaque fields?

[treiher]

You are right. I thought there would be an example, but I couldn't find one. So we should check that in the model.

[jklmnn]

Even if there were examples. How would we write and read the fields without getters and setters?

Aside from that the properties to prove the length was:

First mod 8 = 1
Length mod 8 = 0

This also requires that the message itself is also byte aligned. If this is not the case the First_Bit_Index and Last_Bit_Index are not reversible with Byte_Index which is required.

[treiher]

This also requires that the message itself is also byte aligned.

That is true. I cannot see a way to misalign a message as soon as the alignment is checked for opaque fields.