Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyRFLX: let bytestring fail on invalid message #423

Closed
jklmnn opened this issue Aug 31, 2020 · 1 comment · Fixed by #431
Closed

PyRFLX: let bytestring fail on invalid message #423

jklmnn opened this issue Aug 31, 2020 · 1 comment · Fixed by #431
Assignees
@jklmnn
Projects
RecordFlux 0.5

Comments

@jklmnn
Copy link
Member

jklmnn commented Aug 31, 2020 •
edited
Loading

The bytestring method should fail if a message is not valid and does not have a valid checksum. Also accessing fields of invalid messages should raise an exception.
@jklmnn jklmnn created this issue from a note in RecordFlux 0.5 (To do) Aug 31, 2020
@jklmnn jklmnn mentioned this issue Sep 1, 2020
Merged
@jklmnn jklmnn moved this from To do to In progress in RecordFlux 0.5 Sep 2, 2020
@jklmnn jklmnn self-assigned this Sep 2, 2020
jklmnn added a commit that referenced this issue Sep 2, 2020
@jklmnn
Raise exception when generating bytestring from invalid message
af08ff9 
ref #423
@jklmnn
Copy link
Member Author

jklmnn commented Sep 2, 2020

As discussed the implications on accessing fields have to be reevaluated after #422.

jklmnn added a commit that referenced this issue Sep 3, 2020
@jklmnn
Raise exception when generating bytestring from invalid message
2b9c393 
ref #423
jklmnn added a commit that referenced this issue Sep 3, 2020
@jklmnn
Raise exception when generating bytestring from invalid message
ad7e9ad 
ref #423
@senier senier moved this from In progress to Done in RecordFlux 0.5 Sep 3, 2020
@jklmnn jklmnn closed this as completed Sep 3, 2020
RecordFlux 0.5 automation moved this from Done to Merged Sep 3, 2020
@jklmnn jklmnn reopened this Sep 3, 2020
RecordFlux 0.5 automation moved this from Merged to In progress Sep 3, 2020
@jklmnn jklmnn moved this from In progress to Done in RecordFlux 0.5 Sep 3, 2020
@jklmnn jklmnn mentioned this issue Sep 3, 2020
Merged
RecordFlux 0.5 automation moved this from Done to Merged Sep 4, 2020
jklmnn added a commit that referenced this issue Sep 4, 2020
@jklmnn
Raise exception when generating bytestring from invalid message
fda9154 
ref #423
@treiher treiher mentioned this issue Aug 4, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jklmnn jklmnn

Labels
None yet
Projects
No open projects
RecordFlux 0.5
  
Merged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 423: Raise exception when generating bytestring from invalid message AdaCore/RecordFlux
1 participant
@jklmnn