Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken message bit index calculation #503

Closed
jklmnn opened this issue Nov 26, 2020 · 2 comments
Closed

Broken message bit index calculation #503

jklmnn opened this issue Nov 26, 2020 · 2 comments
Assignees
Labels
bug pyrflx Related to pyrflx package (Legacy Python API)

Comments

@jklmnn
Copy link
Member

jklmnn commented Nov 26, 2020

Currently the bitindex of a field in a message is calculated inconsistently depending on the context. Most calculations calculate the index of a field by the predecessors first and length. They usually rely on Initial'First being set which is set to 0 in the constructor. This creates two problems:

  • Message'First must be greater than 0
    This results in all calculations made with Initial'First being incompatible to Message'First
  • Message'First is not handled
    Since Initial'First is used as base any change to Message'First by the model might be ignored, and if it is not the results of many calculations are probably wrong

To fix this Initial'First should be set to Message'First and a mechanism is needed to detect if Message'First has been set in the message and to use either this or the default value 1.

@jklmnn jklmnn created this issue from a note in RecordFlux 0.5 (To do) Nov 26, 2020
@jklmnn jklmnn added bug pyrflx Related to pyrflx package (Legacy Python API) labels Nov 26, 2020
@jklmnn jklmnn changed the title PyRFLX: Fix bitindex calculation Broken message bit index calculation Nov 26, 2020
@jklmnn
Copy link
Member Author

jklmnn commented Nov 26, 2020

As discussed Message'First should not be set in the model and can be implementation defined.What is left to do it so set Message'First = Initial'First = 0.

@jklmnn jklmnn moved this from To do to In progress in RecordFlux 0.5 Nov 26, 2020
@jklmnn jklmnn self-assigned this Nov 26, 2020
jklmnn added a commit that referenced this issue Dec 1, 2020
jklmnn added a commit that referenced this issue Dec 1, 2020
jklmnn added a commit that referenced this issue Dec 1, 2020
jklmnn added a commit that referenced this issue Dec 1, 2020
@jklmnn jklmnn moved this from In progress to Done in RecordFlux 0.5 Dec 2, 2020
jklmnn added a commit that referenced this issue Dec 3, 2020
jklmnn added a commit that referenced this issue Dec 4, 2020
jklmnn added a commit that referenced this issue Dec 4, 2020
@jklmnn
Copy link
Member Author

jklmnn commented Dec 7, 2020

Fixed with #501.

@jklmnn jklmnn closed this as completed Dec 7, 2020
RecordFlux 0.5 automation moved this from Done to Merged Dec 7, 2020
@treiher treiher mentioned this issue Aug 4, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pyrflx Related to pyrflx package (Legacy Python API)
Projects
No open projects
RecordFlux 0.5
  
Merged
Development

No branches or pull requests

1 participant