Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve message attributes in message types #729

Closed
4 tasks done
senier opened this issue Aug 10, 2021 · 0 comments · Fixed by #741
Closed
4 tasks done

Resolve message attributes in message types #729

senier opened this issue Aug 10, 2021 · 0 comments · Fixed by #741
Assignees
Labels
bug model Related to model package (e.g., model verification) small Effort of one person-day or less

Comments

@senier
Copy link
Member

senier commented Aug 10, 2021

When substituting message types we currently ignore Message'First, Message'Last and Message'Size completely. This results in invalid specifications with inner expressions referring to outer message attributes.

To resolve this issue we will

  • Substitute Message'Size by Message'Last - Message'First + 1
  • Substitute Message'First by Field'First where Field is the first field of the inner message
  • Substitute Message'Last by the Field'Last where Field is the last field of the inner message (on the respective path).
  • Check that Field leads to final if Message'Last is used in the message type

In addition we should enforce #555 to make sure message are valid.

@senier senier created this issue from a note in RecordFlux 0.6 (To do) Aug 10, 2021
@senier senier self-assigned this Aug 10, 2021
@senier senier added bug model Related to model package (e.g., model verification) small Effort of one person-day or less labels Aug 10, 2021
@senier senier moved this from To do to In progress in RecordFlux 0.6 Aug 11, 2021
senier pushed a commit that referenced this issue Aug 13, 2021
@senier senier moved this from In progress to Under review in RecordFlux 0.6 Aug 13, 2021
RecordFlux 0.6 automation moved this from Under review to Merged Aug 16, 2021
senier pushed a commit that referenced this issue Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug model Related to model package (e.g., model verification) small Effort of one person-day or less
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant