Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect examples in README #879

Closed
treiher opened this issue Dec 17, 2021 · 0 comments · Fixed by #988
Closed

Incorrect examples in README #879

treiher opened this issue Dec 17, 2021 · 0 comments · Fixed by #988

Comments

@treiher
Copy link
Collaborator

treiher commented Dec 17, 2021

The description of the specification example does not match the actual description:

  • Name mismatch: Value_Length/Length
  • Size mismatch for Tag and Length

The example for parsing a TLV.Message is incorrect:

  • Initialize requires argument Written_Last => RFLX.RFLX_Types.To_Last_Bit_Index (Buffer'Last)
@treiher treiher added this to To do in RecordFlux 0.6 via automation Dec 17, 2021
@treiher treiher changed the title Inconsistencies in README Invalid examples in README Feb 7, 2022
@treiher treiher changed the title Invalid examples in README Incorrect examples in README Feb 7, 2022
treiher added a commit that referenced this issue Apr 13, 2022
@treiher treiher self-assigned this Apr 13, 2022
@treiher treiher moved this from To do to Review in RecordFlux 0.6 Apr 13, 2022
treiher added a commit that referenced this issue Apr 13, 2022
RecordFlux 0.6 automation moved this from Review to Done Apr 13, 2022
treiher added a commit that referenced this issue Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant