Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant value used for write buffer size #895

Closed
treiher opened this issue Jan 6, 2022 · 0 comments · Fixed by #1024
Closed

Constant value used for write buffer size #895

treiher opened this issue Jan 6, 2022 · 0 comments · Fixed by #1024
Assignees
Labels
bug generator Related to generator package (SPARK code generation)

Comments

@treiher
Copy link
Collaborator

treiher commented Jan 6, 2022

The Write_Buffer_Size function still uses a constant value of 4096 instead of the actual size of the buffer provided by the allocator. A test should be added that would have detected the issue (e.g., using non-default buffer sizes in a feature test).

Related to #713.

@treiher treiher added bug generator Related to generator package (SPARK code generation) labels Jan 6, 2022
@treiher treiher added this to To do in RecordFlux 0.6 via automation Jan 6, 2022
@treiher treiher self-assigned this May 10, 2022
@treiher treiher moved this from To do to Implementation in RecordFlux 0.6 May 10, 2022
treiher added a commit that referenced this issue May 10, 2022
treiher added a commit that referenced this issue May 10, 2022
treiher added a commit that referenced this issue May 10, 2022
@treiher treiher moved this from Implementation to Review in RecordFlux 0.6 May 10, 2022
RecordFlux 0.6 automation moved this from Review to Done May 10, 2022
treiher added a commit that referenced this issue May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug generator Related to generator package (SPARK code generation)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant