Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type coversion in generated code for Sequence #965

Closed
jklmnn opened this issue Mar 22, 2022 · 0 comments · Fixed by #966
Closed

Missing type coversion in generated code for Sequence #965

jklmnn opened this issue Mar 22, 2022 · 0 comments · Fixed by #966
Assignees
@treiher
Labels
bug generator Related to generator package (SPARK code generation)
Projects
RecordFlux 0.6

Comments

@jklmnn
Copy link
Member

jklmnn commented Mar 22, 2022

When appending items to a sequence the check for the available space in the generated code misses a type conversion. I get the following error in when trying to compile the generated code:

rflx-spdm_responder-session.adb:3601:78: error: invalid operand types for operator "<"
rflx-spdm_responder-session.adb:3601:78: error: left operand has type "Bit_Length" defined at rflx-rflx_generic_types.ads:35, instance at rflx-rflx_types.ads:14
rflx-spdm_responder-session.adb:3601:78: error: right operand has type "Length_16" defined at rflx-spdm.ads:16

This problem can be reproduced with running make test_responder on 24ed3b2ac2614166a9f95c6c1918d2d466a25b72 on issue_7 in the SPDM repository.
@jklmnn jklmnn added the bug label Mar 22, 2022
@jklmnn jklmnn added this to To do in RecordFlux 0.6 via automation Mar 22, 2022
@treiher treiher self-assigned this Mar 23, 2022
@treiher treiher moved this from To do to Implementation in RecordFlux 0.6 Mar 23, 2022
treiher added a commit that referenced this issue Mar 23, 2022
@treiher
Fix missing type conversion in generated code for appending to sequence
db30038 
Ref. #965
@treiher treiher mentioned this issue Mar 23, 2022
Merged
@treiher treiher moved this from Implementation to Review in RecordFlux 0.6 Mar 23, 2022
@treiher treiher added the generator Related to generator package (SPARK code generation) label Mar 23, 2022
RecordFlux 0.6 automation moved this from Review to Done Mar 23, 2022
treiher added a commit that referenced this issue Mar 23, 2022
@treiher
Fix missing type conversion in generated code for appending to sequence
a348d2e 
Ref. #965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@treiher treiher

Labels
bug generator Related to generator package (SPARK code generation)
Projects
No open projects
RecordFlux 0.6
  
Done
Milestone
No milestone
2 participants
@jklmnn @treiher