Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Structural_Valid #986

Closed
treiher opened this issue Apr 11, 2022 · 0 comments · Fixed by #1247
Closed

Rename Structural_Valid #986

treiher opened this issue Apr 11, 2022 · 0 comments · Fixed by #1247
Assignees
@treiher
Labels
architectural decision Discussion of design decision generator Related to generator package (SPARK code generation) small Effort of one person-day or less
Projects
RecordFlux 0.8

Comments

@treiher
Copy link
Collaborator

treiher commented Apr 11, 2022

Context and Problem Statement

The naming of the field status Structural_Valid is grammatically incorrect.

Considered Options

O1 Structurally_Valid

− Quite long

O2 Structured

− Does not really convey the meaning

O3 Regular

− Does not really convey the meaning

O4 Constructed

− Does not really convey the meaning

O5 Well_Formed

+ Used similarly in other contexts like XML

Decision Outcome

O5
@treiher treiher added generator Related to generator package (SPARK code generation) architectural decision Discussion of design decision labels Apr 11, 2022
@treiher treiher added this to To do in RecordFlux 0.6 via automation Apr 11, 2022
@senier senier removed this from To do in RecordFlux 0.6 Aug 23, 2022
@senier senier added this to To do in RecordFlux Future via automation Aug 23, 2022
@treiher treiher added the small Effort of one person-day or less label Oct 28, 2022
@treiher treiher moved this from Medium to High in RecordFlux Future Oct 28, 2022
@senier senier removed this from High in RecordFlux Future Nov 1, 2022
@senier senier added this to To do in RecordFlux 0.8 via automation Nov 1, 2022
@treiher treiher self-assigned this Nov 4, 2022
@treiher treiher moved this from To do to Implementation in RecordFlux 0.8 Nov 4, 2022
@treiher treiher moved this from Implementation to Review in RecordFlux 0.8 Nov 4, 2022
treiher added a commit that referenced this issue Nov 4, 2022
@treiher
Rename Structural_Valid to Well_Formed
0c641e8 
Ref. #986
@treiher treiher mentioned this issue Nov 4, 2022
Merged
RecordFlux 0.8 automation moved this from Review to Done Nov 7, 2022
treiher added a commit that referenced this issue Nov 7, 2022
@treiher
Rename Structural_Valid to Well_Formed
f4319f4 
Ref. #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@treiher treiher

Labels
architectural decision Discussion of design decision generator Related to generator package (SPARK code generation) small Effort of one person-day or less
Projects
No open projects
RecordFlux 0.8
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 986: Rename Structural_Valid to Well_Formed AdaCore/RecordFlux
1 participant
@treiher