Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate the with imports being generated #1022

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented May 10, 2022

This PR fixes potential duplicate with imports by using a set to represent all imports in a package (instead of a list), and the output is stablized by sorting all the imports alphabetically.

@rami3l rami3l requested a review from treiher May 10, 2022 14:30
@treiher treiher added this to Review in RecordFlux 0.6 via automation May 10, 2022
@rami3l rami3l merged commit 946f177 into main May 10, 2022
RecordFlux 0.6 automation moved this from Review to Done May 10, 2022
@rami3l rami3l deleted the fix/duplicate-imports branch May 10, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants