Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 662: Detection of always True conditions #1258

Merged
merged 12 commits into from
Nov 24, 2022
Merged

Issue 662: Detection of always True conditions #1258

merged 12 commits into from
Nov 24, 2022

Conversation

jklmnn
Copy link
Member

@jklmnn jklmnn commented Nov 23, 2022

Closes #662
Closes #1255

senier
senier previously approved these changes Nov 23, 2022
View reviewed changes
treiher
treiher requested changes Nov 23, 2022
View reviewed changes
rflx/error.py Show resolved Hide resolved
rflx/expression.py Outdated Show resolved Hide resolved
tests/data/specs/tlv_with_checksum.rflx Show resolved Hide resolved
tests/unit/model/message_test.py Outdated Show resolved Hide resolved
@jklmnn jklmnn requested a review from treiher November 24, 2022 11:13
@jklmnn jklmnn merged commit a8d6cee into main Nov 24, 2022
@jklmnn jklmnn deleted the issue_662 branch November 24, 2022 15:00
jklmnn added a commit that referenced this pull request Nov 24, 2022
@jklmnn
Clarify add_unsat argument
1050ad3 
ref #1258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senier senier senier approved these changes

@treiher treiher treiher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change RecordFluxError.propagate to only raise exceptions on errors Detection of always True conditions
3 participants
@jklmnn @senier @treiher