Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 182, 205, 238: Scalars with size greater than 57 bit #294

Merged
merged 8 commits into from
Jun 22, 2020

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jun 17, 2020

Summary

  • Use modular integer with No_Wrap_Around as base type for all scalar types
  • Increase size restrictions in model
  • Rewrite conversion functions to allow up to 64-bit scalar types
  • Remove all False_Positive annotations
  • Remove lemmas package and thus dependency to big numbers library

Closes #182
Closes #205
Closes #238

@treiher treiher changed the title Issue 205: Scalars with size greater than 57 bit Issue 182, 205, 238: Scalars with size greater than 57 bit Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #294 into develop will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #294      +/-   ##
===========================================
- Coverage    97.74%   97.69%   -0.05%     
===========================================
  Files           24       24              
  Lines         4083     4082       -1     
  Branches       678      678              
===========================================
- Hits          3991     3988       -3     
- Misses          52       53       +1     
- Partials        40       41       +1     
Impacted Files Coverage Δ
rflx/generator/core.py 98.26% <ø> (-0.39%) ⬇️
rflx/generator/generator.py 98.18% <ø> (ø)
rflx/ada.py 96.93% <100.00%> (ø)
rflx/generator/const.py 100.00% <100.00%> (ø)
rflx/generator/parser.py 97.43% <100.00%> (-0.10%) ⬇️
rflx/model.py 99.49% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c6ce6...5b4d934. Read the comment docs.

@treiher treiher requested review from jklmnn and senier June 17, 2020 11:39
@treiher treiher marked this pull request as ready for review June 17, 2020 11:39
Copy link
Member

@jklmnn jklmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if RFLX_Utils is a good name for the package. Maybe RFLX_Bitops would be better (although I have to admit that the mod operation doesn't exactly fit into bitops).

generated/rflx-rflx_generic_types.adb Outdated Show resolved Hide resolved
generated/rflx-rflx_generic_types.ads Outdated Show resolved Hide resolved
generated/rflx-rflx_generic_types.ads Show resolved Hide resolved
generated/rflx-rflx_utils.adb Outdated Show resolved Hide resolved
@treiher

This comment has been minimized.

treiher added a commit that referenced this pull request Jun 19, 2020
treiher added a commit that referenced this pull request Jun 19, 2020
treiher added a commit that referenced this pull request Jun 19, 2020
@treiher treiher requested review from jklmnn and senier June 19, 2020 15:23
jklmnn
jklmnn previously approved these changes Jun 19, 2020
senier
senier previously approved these changes Jun 19, 2020
@treiher treiher merged commit 941b692 into develop Jun 22, 2020
@treiher treiher deleted the issue_205 branch June 22, 2020 11:38
treiher added a commit that referenced this pull request Jun 22, 2020
treiher added a commit that referenced this pull request Jun 22, 2020
treiher added a commit that referenced this pull request Jun 22, 2020
treiher added a commit that referenced this pull request Jul 23, 2020
treiher added a commit that referenced this pull request Jul 23, 2020
treiher added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalars with size greater than 57 bit Base type overflows integer range Overflow for 64 bit modular types
3 participants