Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 305: Improve performance of expression parsing #306

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jun 26, 2020

Close #305

@treiher treiher requested review from senier and jklmnn June 26, 2020 15:19
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #306 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #306   +/-   ##
========================================
  Coverage    97.74%   97.74%           
========================================
  Files           25       25           
  Lines         4351     4352    +1     
  Branches       714      714           
========================================
+ Hits          4253     4254    +1     
  Misses          58       58           
  Partials        40       40           
Impacted Files Coverage Δ
rflx/parser/grammar.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115153b...f2a4417. Read the comment docs.

@treiher treiher merged commit 3870da6 into develop Jun 29, 2020
@treiher treiher deleted the issue_305 branch June 29, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional parentheses cause significant increase of parsing time
3 participants