Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 312, 313, 314, 315, 316: Prevent compilation errors in generated code #318

Merged
merged 7 commits into from
Jul 3, 2020

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jul 2, 2020

Close #312
Close #313
Close #314
Close #315
Close #316

@treiher treiher requested review from senier and jklmnn July 2, 2020 15:09
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #318 into develop will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
+ Coverage    97.78%   97.83%   +0.05%     
===========================================
  Files           25       25              
  Lines         4387     4398      +11     
  Branches       721      726       +5     
===========================================
+ Hits          4290     4303      +13     
+ Misses          58       57       -1     
+ Partials        39       38       -1     
Impacted Files Coverage Δ
rflx/ada.py 96.93% <100.00%> (-0.01%) ⬇️
rflx/generator/core.py 98.65% <100.00%> (+0.40%) ⬆️
rflx/model.py 99.86% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbddda...4bf7533. Read the comment docs.

jklmnn
jklmnn previously approved these changes Jul 2, 2020
senier
senier previously approved these changes Jul 2, 2020
@treiher treiher dismissed stale reviews from senier and jklmnn via 4bf7533 July 3, 2020 08:11
@treiher treiher requested review from senier and jklmnn July 3, 2020 08:11
@treiher treiher merged commit 9307af6 into develop Jul 3, 2020
@treiher treiher deleted the issue_312 branch July 3, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants