Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 329: Prevent name conflicts between literals and field names #333

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

treiher
Copy link
Collaborator

@treiher treiher commented Jul 9, 2020

Closes #329

@treiher treiher requested review from senier and jklmnn July 9, 2020 11:36
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #333 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #333   +/-   ##
========================================
  Coverage    97.95%   97.95%           
========================================
  Files           25       25           
  Lines         4447     4447           
  Branches       746      746           
========================================
  Hits          4356     4356           
  Misses          54       54           
  Partials        37       37           
Impacted Files Coverage Δ
rflx/generator/common.py 97.60% <ø> (ø)
rflx/generator/core.py 98.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdb0c1...387f673. Read the comment docs.

@treiher treiher merged commit b5e031f into develop Jul 9, 2020
@treiher treiher deleted the issue_329 branch July 9, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name conflicts between literals and field names in SPARK code
3 participants