Remove unnecessary special handling of large fields #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssen
reviewed
Dec 31, 2020
jklmnn
previously approved these changes
Jan 4, 2021
added 2 commits
January 4, 2021 12:15
Good catch - this test is not too useful anymore. I removed it in 7d572e9. Also rebased the branch to current |
jklmnn
approved these changes
Jan 4, 2021
rssen
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #531
I'm not sure why the special handling for unaligned fields / field larger than 7 bit even existed when using a bit array. All test still work, hence I assume removing that code should be OK. Please have a look.