Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 529: Use custom errors instead of assertions for id check #541

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Issue 529: Use custom errors instead of assertions for id check #541

merged 1 commit into from
Jan 11, 2021

Conversation

rssen
Copy link
Contributor

@rssen rssen commented Jan 7, 2021

Closes #529

@rssen rssen requested review from senier and treiher January 7, 2021 12:03
@rssen rssen changed the title Use custom errors instead of assertions for id check Issue 529: Use custom errors instead of assertions for id check Jan 7, 2021
@rssen rssen mentioned this pull request Jan 7, 2021
Merged
treiher
treiher requested changes Jan 7, 2021
View reviewed changes
tests/unit/expression_test.py Outdated Show resolved Hide resolved
rflx/identifier.py Outdated Show resolved Hide resolved
tests/unit/generator_test.py Outdated Show resolved Hide resolved
jklmnn
jklmnn previously approved these changes Jan 7, 2021
View reviewed changes
@rssen rssen requested a review from treiher January 7, 2021 16:14
treiher
treiher requested changes Jan 7, 2021
View reviewed changes
rflx/identifier.py Outdated Show resolved Hide resolved
@rssen rssen requested a review from treiher January 7, 2021 17:02
treiher
treiher previously approved these changes Jan 7, 2021
View reviewed changes
jklmnn
jklmnn previously approved these changes Jan 7, 2021
View reviewed changes
senier
senier previously approved these changes Jan 8, 2021
View reviewed changes
@treiher
Copy link
Collaborator

treiher commented Jan 11, 2021

The branch needs to be rebased to develop.

@rssen rssen dismissed stale reviews from senier, jklmnn, and treiher via 94e5d31 January 11, 2021 12:57
@rssen
Copy link
Contributor Author

rssen commented Jan 11, 2021

Rebased onto develop

@treiher treiher merged commit f2a2e25 into develop Jan 11, 2021
@treiher treiher deleted the issue_529 branch January 11, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treiher treiher treiher approved these changes

@senier senier senier left review comments

@jklmnn jklmnn jklmnn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID class relies on assertion for validity check
4 participants
@rssen @treiher @senier @jklmnn