Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 713: Add commandline option for location of rfi files #871

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

kanigsson
Copy link
Collaborator

  • command line option for rfi files
  • new argument of Parser and Integration for rfi files location
  • move all rfi file handling to Integration class
  • move testing accordingly
  • new test for different location of rfi file

For #713

- command line option for rfi files
- new argument of Parser and Integration for rfi files location
- move all rfi file handling to Integration class
- move testing accordingly
- new test for different location of rfi file

For #713
@kanigsson
Copy link
Collaborator Author

Do you know what's going on with that failed test? Shall I just retry by repushing the commit (e.g. with a slightly different commit message)?

@senier
Copy link
Member

senier commented Dec 8, 2021

Do you know what's going on with that failed test? Shall I just retry by repushing the commit (e.g. with a slightly different commit message)?

I had the same issue lately and it vanished after a while. Looks like an upstream Alire issue. No need to push with a different commit message - you can just hit rerun in the Github actions (after it failed or after you canceled the run).

rflx/integration.py Outdated Show resolved Hide resolved
tests/unit/integration_test.py Outdated Show resolved Hide resolved
@treiher treiher added this to Review in RecordFlux 0.6 via automation Dec 8, 2021
@kanigsson
Copy link
Collaborator Author

I had the same issue lately and it vanished after a while. Looks like an upstream Alire issue. No need to push with a different commit message - you can just hit rerun in the Github actions (after it failed or after you canceled the run).

In this case there were review comments anyway ... But thanks for the info, I was looking for that option elsewhere and couldn't find it.

- method ordering
- improve testcase for rfi file location
@kanigsson kanigsson merged commit 36c8268 into main Dec 9, 2021
RecordFlux 0.6 automation moved this from Review to Done Dec 9, 2021
@kanigsson kanigsson deleted the issue_713 branch December 9, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants