Issue 104: rewrite and extend Insert/Extract subprograms #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subprograms to insert and extract bits from the buffer are extended to little-endian versions. The existing big-endian versions are rewritten for consistency.
treiher
requested changes
Jan 10, 2022
- remove useless preconditions - remove useless mod operation - rename Has_Bits/Has_Bits_Upper into Fits_Into/Fits_Into_Upper - move Shift_Left/Shift_Right functions into private part
treiher
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subprograms to insert and extract bits from the buffer are
extended to little-endian versions.
The existing big-endian versions are rewritten for consistency.