-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log for debugging safe_copy issue during source_packaging #715
Conversation
if isdir(dst): | ||
# dst directory will be replaced by a file having the same | ||
# content as 'src' | ||
e3.log.debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is the same as above.
Better state isdir
?
rm(dst.path, recursive=True, glob=False) | ||
elif islink(dst): | ||
e3.log.debug( | ||
f"safe_copy - debug : NOT islink : src={src}, islink: dst ={dst}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's NOT islink({dst})
# dst symlink will be replaced by a file having the same | ||
# content as 'src' | ||
rm(dst.path, recursive=False, glob=False) | ||
|
||
try: | ||
if dst.basename != src.basename: | ||
e3.log.debug( | ||
f"safe_copy - debug : src:{src} file != dst:{dst} file", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoule mention the basename
no more needed |
Ref: IT-1677