Add log for debugging safe_copy issue during source_packaging #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouigrokon
reviewed
Apr 4, 2024
| if isdir(dst): | ||
| # dst directory will be replaced by a file having the same | ||
| # content as 'src' | ||
| e3.log.debug( |
There was a problem hiding this comment.
This comment is the same as above.
Better state isdir ?
grouigrokon
reviewed
Apr 4, 2024
| rm(dst.path, recursive=True, glob=False) | ||
| elif islink(dst): | ||
| e3.log.debug( | ||
| f"safe_copy - debug : NOT islink : src={src}, islink: dst ={dst}", |
There was a problem hiding this comment.
Here it's NOT islink({dst})
grouigrokon
reviewed
Apr 4, 2024
| # dst symlink will be replaced by a file having the same | ||
| # content as 'src' | ||
| rm(dst.path, recursive=False, glob=False) | ||
|
|
||
| try: | ||
| if dst.basename != src.basename: | ||
| e3.log.debug( | ||
| f"safe_copy - debug : src:{src} file != dst:{dst} file", |
There was a problem hiding this comment.
Shoule mention the basename
|
no more needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: IT-1677