Merge branch 'dev/KP-18636' into 'master'

KP detector for 18636

See merge request eng/libadalang/langkit-query-language!76

lkql_checker/share/lkql/kp/KP-18636.lkql

@@ -0,0 +1,10 @@
+# Flag 'Image applied to objects of a class-wide interface type
+
+@check(message="possible occurrence of KP 18636", impact="22.*,23.*")
+fun kp_18636(node) =
+    node is AttributeRef
+    when node.f_attribute.p_name_is("Image")
+     and node.f_prefix is Name(
+             p_referenced_decl() is ObjectDecl or ParamSpec or GenericFormalObjDecl,
+             p_expression_type() is ClasswideTypeDecl(
+                 p_is_interface_type() is true))

testsuite/tests/checks/KP-18636/p.adb

@@ -0,0 +1,9 @@
+package body P is
+
+   procedure Proc (Object : One'Class) is
+      S : constant String := Object'Image;  --  FLAG
+   begin
+      null;
+   end Proc;
+
+end P;

testsuite/tests/checks/KP-18636/p.ads

@@ -0,0 +1,8 @@
+package P is
+
+   type Root is interface;
+   type One is interface and Root;
+
+   procedure Proc (Object : One'Class);
+
+end P;

testsuite/tests/checks/KP-18636/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/KP-18636/test.out

@@ -0,0 +1,4 @@
+p.adb:4:30: rule violation: possible occurrence of KP 18636
+4 |       S : constant String := Object'Image;  --  FLAG
+  |                              ^^^^^^^^^^^^
+

testsuite/tests/checks/KP-18636/test.yaml

@@ -0,0 +1,3 @@
+driver: 'checker'
+rule_name: KP_18636
+project: 'prj.gpr'