Merge branch 'topic/dw_conv_doc' into 'master'

Document change to Downward_View_Conversions rule See merge request eng/libadalang/langkit-query-language!159
AdaCore · Jan 2, 2024 · fa23099 · fa23099
2 parents 3eb7d09 + 7f7a56f
commit fa23099
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lkql_checker/doc/gnatcheck_rm/predefined_rules.rst b/lkql_checker/doc/gnatcheck_rm/predefined_rules.rst
@@ -280,6 +280,8 @@ Flag downward view conversions.
 
 This rule has no parameters.
 
+This rule will also flag downward view conversions done through access types.
+
 .. rubric:: Example
 
 .. code-block:: ada
@@ -303,9 +305,11 @@ This rule has no parameters.
    package body Foo is
 
       procedure Proc1 (X : in out T1'Class) is
-         Var : T2 := T2 (X);                   --  FLAG
+         Var : T2 := T2 (X);                          --  FLAG
+         X_Acc : T1_Access := X'Unrestricted_Access;
+         Var_2 : T2_Access := T2_Access (X_Acc);      --  FLAG
       begin
-         Proc2 (T2'Class (X));                 --  FLAG
+         Proc2 (T2'Class (X));                        --  FLAG
       end Proc1;
 
       procedure Proc2 (X : in out T2'Class) is

diff --git a/lkql_checker/share/lkql/downward_view_conversions.lkql b/lkql_checker/share/lkql/downward_view_conversions.lkql
@@ -1,4 +1,5 @@
 # Flag downward view conversions.
+# This rule will also flag downward view conversions done through access types.
 
 fun is_downward_conv(expr_type, t) =
     |" Whether converting from `expr_type` to `t` is a downward view conversion