Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve punctuation in documentation #23

Closed
wants to merge 1 commit into from
Closed

Improve punctuation in documentation #23

wants to merge 1 commit into from

Conversation

asarhaddon
Copy link
Contributor

Sphinx fixes such errors, or does not depending on the current locale,
preventing reproducible builds.

Sphinx fixes such errors, or does not depending on the current locale,
preventing reproducible builds.
@t-14
Copy link
Collaborator

t-14 commented May 27, 2022

Our RST files must only contain ASCII characters, so unfortunately we can't accept this PR.

@t-14 t-14 closed this May 27, 2022
@asarhaddon
Copy link
Contributor Author

I had no way to figure this constraint, as dom.rst is currently encoded in UTF-8 in your master branch.
I have adapted my suggestion so that all RST files are encoded in ASCII.
Should I open a new merge request, or is it possible to reopen this one?

@t-14
Copy link
Collaborator

t-14 commented May 29, 2022

I had no way to figure this constraint, as dom.rst is currently encoded in UTF-8 in your master branch.

Yes, this is exceptional since it has one character inside which makes it necessary. Everything else is ASCII though.

Should I open a new merge request, or is it possible to reopen this one?

It can't be reopened apparently since "doc-typo branch was force-pushed or recreated". Let's open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants