Skip to content

Commit

Permalink
OrbitControls: fix Orthographic 'change' event (mrdoob#27424)
Browse files Browse the repository at this point in the history
* OrbitControls: fix Orthographic 'change' event

Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>

* OrbitControls: only recalculate when zoom has changed

Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>

* clean-up

Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>

---------

Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
  • Loading branch information
sciecode authored and AdaRoseCannon committed Jan 15, 2024
1 parent 303dfc9 commit 4960d15
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions examples/jsm/controls/OrbitControls.js
Expand Up @@ -373,10 +373,15 @@ class OrbitControls extends EventDispatcher {
}

} else if ( scope.object.isOrthographicCamera ) {

zoomChanged = scale !== 1;

scope.object.zoom = Math.max( scope.minZoom, Math.min( scope.maxZoom, scope.object.zoom / scale ) );
scope.object.updateProjectionMatrix();
zoomChanged = true;
if ( zoomChanged ) {

scope.object.zoom = Math.max( scope.minZoom, Math.min( scope.maxZoom, scope.object.zoom / scale ) );
scope.object.updateProjectionMatrix();

}

}

Expand Down

0 comments on commit 4960d15

Please sign in to comment.