Proposal for CodeChange

[mmenkhof]

Dear Adam,

please be so kind and change in hooks.py the sub-routine:
def pip_install(packages=None, upgrade=False):
# Build in /tmp or Juju's internal git will be confused
cmd_line = ['pip', 'install', '--src', '/usr/src/']
if packages is None:
return(False)
if upgrade:
cmd_line.append('--upgrade')
if not isinstance(packages, list):
packages = [packages]

for package in packages:
    if package.startswith('svn+') or package.startswith('git+') or package.startswith('hg+') or package.startswith('bzr+'):
        cmd_line.append('-e')
    cmd_line.append(package)

# cmd_line.append('--use-mirrors')
return(subprocess.call(cmd_line))

your current script is not working because you have used for the if statements new lines in "packages for packages" which is not working in python.

[AdamIsrael]

Hello,

What errors are you seeing with that line? I recently changed it, in order to satisfy lint, and I haven't had any problems with it.