Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Additional quality of life changes #23

Merged
merged 22 commits into from
Oct 26, 2016
Merged

Add: Additional quality of life changes #23

merged 22 commits into from
Oct 26, 2016

Conversation

AdamJo
Copy link
Owner

@AdamJo AdamJo commented Oct 24, 2016 •
edited
Loading

  • previous page show match ID maybe more information as well
    • on clip copy to clipboard
  • show when game ends
    • compare current games with previous game and see if something happens.
  • pull cdn on desktop / local on mobile.
    • if a device width is below 500px it will pull from local. else it will pull from the steam CDN.
    • this means mobile users will still be able to save about 1mb per initial load.
    • can easily switch back now to either or if needed.
    • used picutre/source element html tag
  • currently only pull from cdn
  • only last 300 games are stored
    • ran into some stress tests with the boston major open qualifier. went up to 750 and was lagging the previous tab. brought it down to 300 and working fine again.

@AdamJo AdamJo changed the title Add: When game ends / previous Game MatchID / Donate information Add: When game ends / previous Game MatchID / Donate information / CDN Images on Desktop Oct 25, 2016
@AdamJo
chore update with upstream
d65fb10
@AdamJo
refactor() images to point only to the cdn
a8fd899
@AdamJo
ui() clean up error / no api messages
c91bf3b
@AdamJo
feature() WIP game over screen
9a37b77 
CURRENT:
- added function to find if game has ended and in previous games
- created UI for game over screen on map
NEXT:
- add animation for game over screen and victor screen
- test on live game, create mok up for test data
@AdamJo
ui() animation only on the map for night time
3df94e5 
- suggestion by gilgi, this makes the map cleaner and easier to see for
night time.
@AdamJo
chore() add checks for animation
8a41de1
@AdamJo
feature() finish game over animation
b08e9c2 
current: added animation and removed unused/test unused
- linting
@AdamJo
chore() only last 300 games are stored
08b4c13
@AdamJo AdamJo changed the title Add: When game ends / previous Game MatchID / Donate information / CDN Images on Desktop Add: Additional quality of life changes Oct 26, 2016
@AdamJo
chore() move unused images
5c0ac8a 
since I am now pulling from the CDN only I do not need these files.
@AdamJo AdamJo mentioned this pull request Oct 26, 2016
Closed
9 tasks
@AdamJo
chore() update from upstream;
86b11fe
@AdamJo
fix() add safe guard against NaN values
15da1e4 
small bug, this poped up once on the live server and went away fairly
quickly.
@AdamJo
chore() update dependencies
1efc435
@AdamJo AdamJo merged commit 5485c4c into master Oct 26, 2016
@AdamJo AdamJo deleted the finishing-touches branch October 26, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AdamJo