Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting dynamic navigation module #155

Closed
wants to merge 33 commits into from
Closed

Conversation

AdamMc331
Copy link
Owner

@AdamMc331 AdamMc331 commented Apr 5, 2024

Current Status

I'm still debating internally about whether or not to include this in the template, and I'm open to community feedback. There are a couple changes I'm still looking to make:

  1. I may rename DynamicNavigation* to AdaptiveNavigation* as I think that's a little more descriptive and a term we're used to.
  2. I may include a sample module/activity/something in addition to the README that shows how to render this setup. Some actual code users can explore in their IDE.

Summary

Adds a new module with a dynamic navigation container, so the users of this template can use that as a root composable, passing in a NavigationType, and get for free an implementation of three different navigation solutions based on window width.

How It Was Tested

Compose previews based on navigation type.

Screenshot/Gif

Dynamic Nav Preview Screenshot 2024-04-10 at 9 16 22 PM

Copy link

github-actions bot commented Apr 5, 2024

1 Warning
⚠️ Please consider breaking up this pull request.
2 Messages
📖 Thanks @AdamMc331!
📖

The following dependencies have later milestone versions:

  • androidx.compose.compiler:compiler [1.5.12 -> 1.5.14]
    https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.14
  • com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.9.23-1.0.20 -> 1.9.24-1.0.20]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing [1.9.23-1.0.20 -> 1.9.24-1.0.20]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing-api [1.9.23-1.0.20 -> 1.9.24-1.0.20]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing-cmdline [1.9.23-1.0.20 -> 1.9.24-1.0.20]
    https://goo.gle/ksp
  • org.jetbrains.kotlin:kotlin-gradle-plugin [1.9.23 -> 1.9.24]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-stdlib [1.9.23 -> 1.9.24]
    https://kotlinlang.org/

Failed to determine the latest version for the following dependencies (use –info for details):

  • com.google.testing.platform:android-driver-instrumentation
  • com.google.testing.platform:android-test-plugin
  • com.google.testing.platform:core
  • com.google.testing.platform:launcher
  • io.gitlab.arturbosch.detekt:detekt-cli
    1.23.6

Gradle current updates:

  • Gradle: [8.7: UP-TO-DATE]

Generated by 🚫 Danger

@AdamMc331 AdamMc331 changed the title [WIP] Considering a dynamic nav module... Supporting dynamic navigation module Apr 11, 2024
@AdamMc331 AdamMc331 added the enhancement New feature or request label Apr 14, 2024
@AdamMc331 AdamMc331 added the question Further information is requested label Apr 14, 2024
@AdamMc331
Copy link
Owner Author

I think I'll be closing this in favor of the new NavigationSuiteScaffold: https://developer.android.com/develop/ui/compose/layouts/adaptive/build-adaptive-navigation

@AdamMc331
Copy link
Owner Author

AdamMc331 commented May 24, 2024

Yep, played around with the new NavigationSuiteScaffold and that does almost exactly this (does not have the permanent nav drawer idea).

JK it even has that: https://developer.android.com/develop/ui/compose/layouts/adaptive/build-adaptive-navigation#customize_navigation_types

@AdamMc331 AdamMc331 closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants