-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting dynamic navigation module #155
Conversation
Generated by 🚫 Danger |
navigation/src/main/java/template/navigation/DynamicNavigationContainer.kt
Outdated
Show resolved
Hide resolved
I think I'll be closing this in favor of the new |
Yep, played around with the new NavigationSuiteScaffold and that does almost exactly this (does not have the permanent nav drawer idea). JK it even has that: https://developer.android.com/develop/ui/compose/layouts/adaptive/build-adaptive-navigation#customize_navigation_types |
Current Status
I'm still debating internally about whether or not to include this in the template, and I'm open to community feedback. There are a couple changes I'm still looking to make:
DynamicNavigation*
toAdaptiveNavigation*
as I think that's a little more descriptive and a term we're used to.Summary
Adds a new module with a dynamic navigation container, so the users of this template can use that as a root composable, passing in a
NavigationType
, and get for free an implementation of three different navigation solutions based on window width.How It Was Tested
Compose previews based on navigation type.
Screenshot/Gif
Dynamic Nav Preview