Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dialog composable for iOS & Android #317

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Conversation

AdamMc331
Copy link
Owner

Summary

On Android, using default component. On iOS, using a custom written pop up.

How It Was Tested

Manually tested on each platform.

Screenshot/Gif

Android Dialog

AndroidDialog

iOS Dialog

Simulator Screen Shot - iPhone 14 Pro - 2023-07-13 at 19 19 44

@github-actions
Copy link

1 Message
📖

The following dependencies have later milestone versions:

  • androidx.compose.compiler:compiler [1.4.6 -> 1.4.8]
    https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.4.8
  • com.android.tools.utp:android-device-provider-ddmlib [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-device-provider-gradle [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-host-additional-test-output [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-host-coverage [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-host-device-info [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-host-logcat [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-host-retention [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.android.tools.utp:android-test-plugin-result-listener-gradle [31.0.0 -> 31.0.2]
    https://developer.android.com/studio/build
  • com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.8.20-1.0.11 -> 1.9.0-1.0.11]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing [1.8.20-1.0.11 -> 1.9.0-1.0.11]
    https://goo.gle/ksp
  • org.jacoco:org.jacoco.ant [0.8.8 -> 0.8.10]
    http://jacoco.org
  • org.jetbrains.intellij.deps:intellij-coverage-agent [1.0.683 -> 1.0.725]
    https://github.com/JetBrains/intellij-coverage
  • org.jetbrains.intellij.deps:intellij-coverage-reporter [1.0.683 -> 1.0.725]
    https://github.com/JetBrains/intellij-coverage
  • org.jetbrains.kotlin:kotlin-annotation-processing-gradle [1.8.20 -> 1.9.0]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-stdlib [1.8.20 -> 1.9.0]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-stdlib-jdk8 [1.8.22 -> 1.9.0]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-test [1.8.20 -> 1.9.0]
    https://kotlinlang.org/

Failed to determine the latest version for the following dependencies (use –info for details):

  • androidx.baselineprofile:androidx.baselineprofile.gradle.plugin
  • com.google.testing.platform:android-driver-instrumentation
  • com.google.testing.platform:android-test-plugin
  • com.google.testing.platform:core
  • com.google.testing.platform:launcher

Gradle current updates:

  • Gradle: [8.2 -> 8.2.1]

Generated by 🚫 Danger

@AdamMc331 AdamMc331 merged commit 6cfab3c into development Jul 14, 2023
8 checks passed
@AdamMc331 AdamMc331 deleted the ios_dialog branch July 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant