Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally navigating to add task dialog/screen based on window size. #115

Merged
merged 4 commits into from Mar 6, 2022

Conversation

AdamMc331
Copy link
Owner

If not a compact device, show a dialog. Otherwise, navigate to screen version.

@AdamMc331 AdamMc331 added this to In progress in Design/Branding via automation Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

2 Messages
📖 Thanks @AdamMc331!
📖

The following dependencies have later milestone versions:

  • androidx.compose.compiler:compiler [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.1.1
  • androidx.compose.ui:ui [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-ui#1.1.1
  • androidx.compose.ui:ui-test-junit4 [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-ui#1.1.1
  • androidx.compose.ui:ui-test-manifest [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-ui#1.1.1
  • androidx.compose.ui:ui-tooling [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-ui#1.1.1
  • androidx.compose.ui:ui-tooling-preview [1.1.0 -> 1.1.1]
    https://developer.android.com/jetpack/androidx/releases/compose-ui#1.1.1
  • androidx.lifecycle:lifecycle-runtime-ktx [2.4.0 -> 2.4.1]
    https://developer.android.com/jetpack/androidx/releases/lifecycle#2.4.1
  • androidx.navigation:navigation-compose [2.4.0 -> 2.4.1]
    https://developer.android.com/jetpack/androidx/releases/navigation#2.4.1
  • androidx.room:room-compiler [2.4.1 -> 2.4.2]
    https://developer.android.com/jetpack/androidx/releases/room#2.4.2
  • androidx.room:room-ktx [2.4.1 -> 2.4.2]
    https://developer.android.com/jetpack/androidx/releases/room#2.4.2
  • androidx.room:room-runtime [2.4.1 -> 2.4.2]
    https://developer.android.com/jetpack/androidx/releases/room#2.4.2
  • com.google.accompanist:accompanist-insets-ui [0.21.2-beta -> 0.23.1]
    https://github.com/google/accompanist/
  • com.google.accompanist:accompanist-navigation-animation [0.21.2-beta -> 0.23.1]
    https://github.com/google/accompanist/
  • com.google.accompanist:accompanist-systemuicontroller [0.21.2-beta -> 0.23.1]
    https://github.com/google/accompanist/
  • com.google.dagger:hilt-android [2.40.5 -> 2.41]
    https://github.com/google/dagger
  • com.google.dagger:hilt-compiler [2.40.5 -> 2.41]
    https://github.com/google/dagger
  • com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.6.10-1.0.2 -> 1.6.10-1.0.4]
    https://goo.gle/ksp
  • com.pinterest:ktlint [0.43.2 -> 0.44.0]
    https://github.com/pinterest/ktlint
  • io.github.vanpra.compose-material-dialogs:datetime [0.6.2 -> 0.6.3]
    https://github.com/vanpra/compose-material-dialogs
  • io.mockk:mockk [1.12.2 -> 1.12.3]
    http://mockk.io

Failed to determine the latest version for the following dependencies (use –info for details):

  • androidx.compose.material3:material3
  • io.github.raamcosta.compose-destinations:animations-core
  • io.github.raamcosta.compose-destinations:ksp

Gradle current updates:

  • Gradle: [7.3 -> 7.4]

Generated by 🚫 Danger

@coveralls
Copy link

coveralls commented Mar 3, 2022

Coverage Status

Coverage decreased (-1.4%) to 48.642% when pulling 3271609 on add_task_dialog_large_screens into 974af03 on development.

@AdamMc331 AdamMc331 merged commit 7fd2a7a into development Mar 6, 2022
Design/Branding automation moved this from In progress to Done Mar 6, 2022
@AdamMc331 AdamMc331 deleted the add_task_dialog_large_screens branch March 6, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants