Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing race condition marking multiple tasks as complete. #169

Merged
merged 6 commits into from
Feb 10, 2023

Conversation

AdamMc331
Copy link
Owner

Summary

We commit to DB right away, and also tweak our state to support a queue of alert messages, which are shown one at a time.

How It Was Tested

Manual testing (maybe UI tests? 馃憖)

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

1 Warning
鈿狅笍 Please add labels to this PR.
2 Messages
馃摉 Thanks @AdamMc331!
馃摉

The following dependencies have later milestone versions:

  • androidx.activity:activity-compose [1.4.0 -> 1.6.1]
    https://developer.android.com/jetpack/androidx/releases/activity#1.6.1
  • androidx.appcompat:appcompat [1.4.1 -> 1.6.1]
    https://developer.android.com/jetpack/androidx/releases/appcompat#1.6.1
  • androidx.compose.compiler:compiler [1.4.0-alpha02 -> 1.4.2]
    https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.4.2
  • androidx.core:core-ktx [1.7.0 -> 1.9.0]
    https://developer.android.com/jetpack/androidx/releases/core#1.9.0
  • androidx.lifecycle:lifecycle-runtime-ktx [2.4.1 -> 2.5.1]
    https://developer.android.com/jetpack/androidx/releases/lifecycle#2.5.1
  • androidx.navigation:navigation-compose [2.4.2 -> 2.5.3]
    https://developer.android.com/jetpack/androidx/releases/navigation#2.5.3
  • androidx.room:room-compiler [2.4.2 -> 2.5.0]
    https://developer.android.com/jetpack/androidx/releases/room#2.5.0
  • androidx.room:room-ktx [2.4.2 -> 2.5.0]
    https://developer.android.com/jetpack/androidx/releases/room#2.5.0
  • androidx.room:room-runtime [2.4.2 -> 2.5.0]
    https://developer.android.com/jetpack/androidx/releases/room#2.5.0
  • androidx.test.espresso:espresso-core [3.4.0 -> 3.5.1]
    https://developer.android.com/testing
  • androidx.test.ext:junit [1.1.3 -> 1.1.5]
    https://developer.android.com/testing
  • app.cash.turbine:turbine [0.7.0 -> 0.12.1]
    https://github.com/cashapp/turbine/
  • com.google.accompanist:accompanist-insets-ui [0.23.1 -> 0.28.0]
    https://github.com/google/accompanist/
  • com.google.accompanist:accompanist-navigation-animation [0.23.1 -> 0.28.0]
    https://github.com/google/accompanist/
  • com.google.accompanist:accompanist-systemuicontroller [0.23.1 -> 0.28.0]
    https://github.com/google/accompanist/
  • com.google.android.material:material [1.5.0 -> 1.8.0]
    https://github.com/material-components/material-components-android
  • com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing-api [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.protobuf:com.google.protobuf.gradle.plugin [0.8.17 -> 0.9.2]
  • com.google.protobuf:protobuf-javalite [3.18.0 -> 3.21.12]
    https://developers.google.com/protocol-buffers/
  • com.pinterest:ktlint [0.45.2 -> 0.48.2]
    https://github.com/pinterest/ktlint
  • io.mockk:mockk [1.12.2 -> 1.13.4]
    https://mockk.io
  • org.jetbrains.kotlin:kotlin-annotation-processing-gradle [1.7.21 -> 1.8.10]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-stdlib [1.7.21 -> 1.8.10]
    https://kotlinlang.org/
  • org.jetbrains.kotlinx:kotlinx-coroutines-test [1.6.0 -> 1.6.4]
    https://github.com/Kotlin/kotlinx.coroutines

Failed to determine the latest version for the following dependencies (use 鈥搃nfo for details):

  • io.github.raamcosta.compose-destinations:animations-core
  • io.github.raamcosta.compose-destinations:ksp

Gradle current updates:

  • Gradle: [7.3.3 -> 7.6]

Generated by 馃毇 Danger

@coveralls
Copy link

Coverage Status

Coverage: 44.157% (+0.3%) from 43.848% when pulling d313c1b on TOA-165/marking_tasks_done into 0ff6873 on development.

@AdamMc331 AdamMc331 merged commit a7d8ca3 into development Feb 10, 2023
@AdamMc331 AdamMc331 deleted the TOA-165/marking_tasks_done branch February 10, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants