Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive navigation types. #181

Merged
merged 6 commits into from Mar 2, 2023
Merged

Conversation

AdamMc331
Copy link
Owner

@AdamMc331 AdamMc331 commented Mar 2, 2023

Summary

Added custom navigation types (bottom nav, nav rail, permanent nav drawer) based on screen width. This is for #179.

How It Was Tested

Manual testing using resizable emulator.

Screenshot/Gif

Permanent Nav Drawer

PermanentNavDrawer

@AdamMc331 AdamMc331 added the enhancement New feature or request label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

2 Messages
📖 Thanks @AdamMc331!
📖

The following dependencies have later milestone versions:

  • androidx.compose.compiler:compiler [1.4.0-alpha02 -> 1.4.3]
    https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.4.3
  • androidx.navigation:navigation-compose [2.4.2 -> 2.5.3]
    https://developer.android.com/jetpack/androidx/releases/navigation#2.5.3
  • com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.devtools.ksp:symbol-processing-api [1.7.21-1.0.8 -> 1.8.10-1.0.9]
    https://goo.gle/ksp
  • com.google.protobuf:com.google.protobuf.gradle.plugin [0.8.17 -> 0.9.2]
  • com.google.protobuf:protobuf-javalite [3.18.0 -> 3.22.0]
    https://developers.google.com/protocol-buffers/
  • com.google.protobuf:protoc [3.21.12 -> 3.22.0]
    https://developers.google.com/protocol-buffers/
  • com.pinterest:ktlint [0.45.2 -> 0.48.2]
    https://github.com/pinterest/ktlint
  • org.jetbrains.kotlin:kotlin-annotation-processing-gradle [1.7.21 -> 1.8.10]
    https://kotlinlang.org/
  • org.jetbrains.kotlin:kotlin-stdlib [1.7.21 -> 1.8.10]
    https://kotlinlang.org/
  • org.jetbrains.kotlinx:kotlinx-coroutines-test [1.6.0 -> 1.6.4]
    https://github.com/Kotlin/kotlinx.coroutines

Failed to determine the latest version for the following dependencies (use –info for details):

  • io.github.raamcosta.compose-destinations:animations-core
  • io.github.raamcosta.compose-destinations:ksp

Gradle current updates:

  • Gradle: [7.3.3 -> 8.0.1]

Generated by 🚫 Danger

@coveralls
Copy link

coveralls commented Mar 2, 2023

Coverage Status

Coverage: 67.129% (-2.5%) from 69.638% when pulling 51aa507 on TOA-179/adaptive_layouts into a2767cf on development.

Comment on lines +27 to +28
minWidth = 200.dp,
maxWidth = 200.dp,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These hardcoded numbers are sketchy, can we do this differently?

Also may want to consider padding within this sheet in the future so buttons aren't going right to edge of the screen.

@AdamMc331 AdamMc331 merged commit 6fd6376 into development Mar 2, 2023
@AdamMc331 AdamMc331 deleted the TOA-179/adaptive_layouts branch March 2, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants