-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive navigation types. #181
Conversation
Generated by 🚫 Danger |
...c/main/java/com/adammcneilly/toa/core/ui/components/navigation/TOANavigationDrawerContent.kt
Outdated
Show resolved
Hide resolved
minWidth = 200.dp, | ||
maxWidth = 200.dp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These hardcoded numbers are sketchy, can we do this differently?
Also may want to consider padding within this sheet in the future so buttons aren't going right to edge of the screen.
Summary
Added custom navigation types (bottom nav, nav rail, permanent nav drawer) based on screen width. This is for #179.
How It Was Tested
Manual testing using resizable emulator.
Screenshot/Gif
Permanent Nav Drawer