Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding description about proxys to readme #86

Merged
merged 5 commits into from Mar 25, 2020

Conversation

fnaquira
Copy link

I was struggling before finding this on the issue section. I think it should be on the main readme because some people are still new to some params on Express.

@coveralls
Copy link

coveralls commented Mar 24, 2020

Coverage Status

Coverage remained the same at 97.543% when pulling aa7d1b1 on fnaquira:readme-proxy into bc48c35 on AdamPflug:master.

@AdamPflug
Copy link
Owner

I think you're right that this is worth including. Could you also include a link to the relevant express documentation and a warning that the value "true" would allow for bypass of the express brute functionally https://expressjs.com/en/guide/behind-proxies.html

@fnaquira
Copy link
Author

Now it is. Thank you for the consideration.

Looks like a file that shouldn't have been committed
Minor updates to the language for the proxy servers information
2 more small tweaks to the language
@AdamPflug AdamPflug merged commit ab4b4e1 into AdamPflug:master Mar 25, 2020
@AdamPflug
Copy link
Owner

Thanks for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants