Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Introduce Storage Access Framework #172

Closed
K1rakishou opened this issue Jul 6, 2019 · 2 comments · Fixed by #292
Closed

[IMPROVEMENT] Introduce Storage Access Framework #172

K1rakishou opened this issue Jul 6, 2019 · 2 comments · Fixed by #292
Assignees
@K1rakishou
Labels
enhancement New feature or request

Comments

@K1rakishou
Copy link

K1rakishou commented Jul 6, 2019 •
edited

So we can have the SD Card support and to prepare for the future Android R release where they introduce the Scoped Storage which will break everything for us. Also to refactor the file manipulation to use SAF. At least for saving threads/images/other files that take space.
Gonna implement it myself.
@K1rakishou K1rakishou changed the title [IMPROVEMENT] Introduce SAF [IMPROVEMENT] Introduce Storage Access Framework Jul 6, 2019
@Adamantcheese Adamantcheese added the enhancement New feature or request label Jul 9, 2019
@Adamantcheese
Copy link
Owner

You may want to look at this stale branch from Clover by the way, Floens was trying to do this a while ago. https://github.com/Floens/Clover/tree/external-storage-support

@K1rakishou
Copy link
Author

Thanks. I see there is a lot of code to handle SAF on both pre and post lollipop devices. Since we don't support pre lollipop devices we don't need that and it makes things a little bit easier. Btw, I already have SAF support for importing/exporting settings and file cache. What is left is thread saving, but it is not merged yet, and I guess that's it (Maybe I forgot something).

@Adamantcheese Adamantcheese added the wontfix This will not be worked on label Jul 15, 2019
@Adamantcheese Adamantcheese removed the wontfix This will not be worked on label Jul 18, 2019
@Adamantcheese Adamantcheese reopened this Jul 18, 2019
@Adamantcheese Adamantcheese mentioned this issue Aug 2, 2019
Closed
K1rakishou added a commit that referenced this issue Aug 10, 2019
@K1rakishou
(#172) SAF base API implementation
e42adbd
K1rakishou added a commit that referenced this issue Aug 10, 2019
@K1rakishou
(#172) Couple of little code improvements
f537fdf
@K1rakishou K1rakishou mentioned this issue Aug 10, 2019
Merged
K1rakishou added a commit that referenced this issue Aug 11, 2019
@K1rakishou
(#172) Comments and more File API methods
b08d175
K1rakishou added a commit that referenced this issue Aug 11, 2019
@K1rakishou
(#172) Settings exporting/importing now works with SAF
d26cdcf
K1rakishou added a commit that referenced this issue Aug 11, 2019
@K1rakishou
(#172) Image saving now works (with bugs) with SAF
9d61e02
K1rakishou added a commit that referenced this issue Aug 17, 2019
@K1rakishou
(#172) SAF fixes:
05606fc 
Now ExternalFiles uses DocumentFile().listFiles() to find a file inside a directory. It's implemented this way because, apparently, it's the only way to get a fully working DocumentFile that supports such operations as exists(), getName(), canRead()/canWrite(), delete() etc and which getParent() returns an actual file and not the null. This slow, but I don't know another way to do this so that everything works as expected.
K1rakishou added a commit that referenced this issue Aug 17, 2019
@K1rakishou
(#172) Image saving now works with SAF!
29cce2a 
Add more tests for AbstractFile
K1rakishou added a commit that referenced this issue Aug 18, 2019
@K1rakishou
(#172) Remove fileManager.fromAbstractFile() method, add AbstractFile…
ff93a34 
….clone() method
K1rakishou added a commit that referenced this issue Aug 18, 2019
@K1rakishou
(#172) ImageSaving now works with both RawFiles and ExternalFiles (vi…
37c3a83 
…a SAF)

Bring back SaveLocationController so that people can choose whether they want to use SAF or not (or in case of a bug)
K1rakishou added a commit that referenced this issue Aug 18, 2019
@K1rakishou
(#172) Add comments. Remove duplicate name() method
b61d619
K1rakishou added a commit that referenced this issue Aug 18, 2019
@K1rakishou
(#172) Comments, refactoring and bug fixes. ImageSaving now work with…
2b692ab 
… sub directories (site name/board code/boar

AbstractFile.findFile() now returns a new AbstractFile instead of DocumentFile
Fix RawFile.createNew() which would create a file when it should create directory
Implement RawFile.findFile()
K1rakishou added a commit that referenced this issue Aug 18, 2019
@K1rakishou
(#172) Fixes and refactoring
a75df6c 
Fix file/directory choosers would not remove the callback from the callback map when we have no activity to handle our intent. Also no message would have been shown in such case.
Give the use a choice when exporting settings whether he wants to open an existing settings file to overwrite it or create a new separate file.
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Add comments
11bde35
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Add local threads location setting (which is selected by the u…
0b5de59 
…ser via SAF)
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Threads should now work with SAF (not tested yet)
9946068
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Make most of the methods in AbstractFile immutable because it …
b4f288b 
…makes more sense this way
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Tests for write to a SAF file, checking it's length and then r…
3e4f8a7 
…eading back from it
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Lots of improvements/fixes etc
4044b72 
Separate local threads download directory from the save location (app base dir) directory. Basically user can now choose separate directories where images or local threads will be stored (both work with SAF and the old API).
Make ThreadSaveManager work with AbstractFile instead of ExternalFile so that the user can decide for themselves whether to use SAF or the old API.
Local threads now work with AbstractFiles. Some classes had to be changed to use RawFile instead of simple File.
Convert couple of classes to Kotlin.
More tests for the testMethod.
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Fix FileCacheDownloader bug where the output file wouldn't be …
941a3d2 
…created because it has no extension
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Return back lost SaveLocationController
b2878be
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Merge with dev branch
1269cb0
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Remove empty files
478e3a7
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Fix grammar mistakes
6772d78
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Fix media scanner scanning file with disabled setting
a38b337 
Fix Uri segments not being encoded when appended
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Remove testMethod when choosing local threads location (since …
3e79291 
…it breaks the app and don't test anything useful)
K1rakishou added a commit that referenced this issue Aug 25, 2019
@K1rakishou
(#172) Revert strict mode back
c0492b7
K1rakishou added a commit that referenced this issue Sep 3, 2019
@K1rakishou
(#172) Merge branch 'cheese-multi-feature' into (#172)-storage-access…
b297828 
…-framework

# Conflicts:
#	Kuroba/app/src/main/java/com/github/adamantcheese/chan/core/repository/ImportExportRepository.java
#	Kuroba/app/src/main/res/values/strings.xml
#	Kuroba/build.gradle
K1rakishou added a commit that referenced this issue Sep 3, 2019
@K1rakishou
(#172) Attempt to implement migration from one local threads base dir…
98f45e7 
…ectory to another

Basically, when a user want to change a local threads directory to another one (let's say they had it on sd-card and then bought another one and want to use it from now on). This is kinda working but it's fucking hacky and some parts of it are really slow.
Fixed a bug with save thread icon being set to the default state when it should be set to stopped state
K1rakishou added a commit that referenced this issue Oct 26, 2019
@K1rakishou
(#172) Migrate to a separate (home made) library that handles SAF bul…
4861305 
…lshit a little bit more gracefully, called Fuck Storage Access Framework

Fuck
Storage
Access
Framework
K1rakishou added a commit that referenced this issue Oct 26, 2019
@K1rakishou
(#172) Significantly improved speed of local threads downloading
b2ce0b9
K1rakishou added a commit that referenced this issue Oct 26, 2019
@K1rakishou
(#172) Fix a bug where the downloading thread won't be marked as stop…
fcde52d 
…ped in the database when stopping it by clicking the "save thread" button
K1rakishou added a commit that referenced this issue Oct 26, 2019
@K1rakishou
(#172) SAF integration is completed
49b1f69 
Add ability to delete old base directory after moving files into the new one
Small fixes for thread album downloading where folder and file names would not be sanitized
K1rakishou added a commit that referenced this issue Oct 26, 2019
@K1rakishou
(#172) Move all strings to resources
5fac46a
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Update Fuck-Storage-Access-Framework to the latest release ver…
1eb7521 
…sion
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Use generic base newBaseDirectoryFile when calling it from the…
24d792d 
… kotlin's functions
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Merge remote-tracking branch 'remotes/origin/multi-feature' in…
2b30039 
…to (#172)-storage-access-framework

# Conflicts:
#	Kuroba/app/build.gradle
#	README.md
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Merge with develop
8c2f6a6
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Fix compilation error
97a7b2b
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Fix image saving related bugs, like file separators filtered i…
0184fab 
…n the paths thus resulting in losing the sub directories

Fix shared_prefs importing/exporting for dev builds (wrong appId was used)
Extract MediaSettingsControllerCallbacks into it's own class to avoid compilation errors
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Fix ImageLoaderV2 setting bitmap into a request field (haha)
ff2d6c1 
Additional active local threads checks before allowing the user to change base dir for local threads
Some strings that were forgotten about were moved to resources
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Add a warning alert dialog that will be shown when the user at…
5fe98c2 
…tempts to export a directory path that is located in a directory using SAF
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Remove merge conflict marker from travis.yml
4dba625
K1rakishou added a commit that referenced this issue Oct 27, 2019
@K1rakishou
(#172) Set the CURRENT_EXPORT_SETTINGS_VERSION to what it should be (5)
8e90850
Adamantcheese added a commit that referenced this issue Oct 31, 2019
@Adamantcheese
Merge remote-tracking branch 'origin/(#172)-storage-access-framework'…
e3393f6 
… into multi-feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@K1rakishou K1rakishou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#172) Storage Access Framework Integration Adamantcheese/Kuroba
2 participants
@Adamantcheese @K1rakishou